From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Jon ERNST <jonernst@gmx.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [ext4] extent tree es_len can be zero?
Date: Thu, 2 May 2013 10:55:22 +0800 [thread overview]
Message-ID: <20130502025522.GA6385@gmail.com> (raw)
In-Reply-To: <20130430045920.296280@gmx.com>
On Tue, Apr 30, 2013 at 12:59:19AM -0400, Jon ERNST wrote:
> Hi ,list,
>
> extent tree es_len can be zero?
> if we call ext4_es_end when es_len is zero, it will have problem.
>
>
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index 95796a1..49a8da2 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -108,7 +108,7 @@
> * tree are ordered by logical block no.
> *
> * -- operations on a extent status tree
> - * There are three important operations on a delayed extent tree: find
> + * There are three important operations on a delayed extent tree: finding
> * next extent, adding a extent(a range of blocks) and removing a extent.
> *
> * -- race on a extent status tree
> @@ -195,7 +195,7 @@ static void ext4_es_print_tree(struct inode *inode)
>
> static inline ext4_lblk_t ext4_es_end(struct extent_status *es)
> {
> - BUG_ON(es->es_lblk + es->es_len < es->es_lblk);
> + BUG_ON(es->es_lblk + es->es_len <= es->es_lblk);
Hi Jon,
Thanks for looking at the code. When ext4_es_end is called, es_len
shouldn't be zero because we always get 'es' from extent status tree,
and we never save an 'es' whose length is zero. So we don't need to
worry about this.
Regards,
- Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-05-02 2:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 4:59 [ext4] extent tree es_len can be zero? Jon ERNST
2013-05-02 2:55 ` Zheng Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502025522.GA6385@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=jonernst@gmx.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).