* [PATCH] libext2fs: fix return value
@ 2013-05-04 5:05 Mike Frysinger
2013-05-04 23:55 ` Theodore Ts'o
0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2013-05-04 5:05 UTC (permalink / raw)
To: linux-ext4
The ext2fs_test_block_bitmap_range2 func is not a void, so make sure we
return a value. I picked EINVAL as it looks like what other things in
this func use.
URL: http://bugs.gentoo.org/467986
Reported-by: Vicente Olivert Riera <vincent@gentoo.org>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
lib/ext2fs/gen_bitmap64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ext2fs/gen_bitmap64.c b/lib/ext2fs/gen_bitmap64.c
index 42a97d4..44ac499 100644
--- a/lib/ext2fs/gen_bitmap64.c
+++ b/lib/ext2fs/gen_bitmap64.c
@@ -658,7 +658,7 @@ int ext2fs_test_block_bitmap_range2(ext2fs_block_bitmap bmap,
if ((block < bmap->start) || (block+num-1 > bmap->end)) {
ext2fs_warn_bitmap(EXT2_ET_BAD_BLOCK_TEST, block,
bmap->description);
- return;
+ return EINVAL;
}
return bmap->bitmap_ops->test_clear_bmap_extent(bmap, block, num);
--
1.8.2.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] libext2fs: fix return value
2013-05-04 5:05 [PATCH] libext2fs: fix return value Mike Frysinger
@ 2013-05-04 23:55 ` Theodore Ts'o
2013-05-05 0:58 ` Mike Frysinger
0 siblings, 1 reply; 5+ messages in thread
From: Theodore Ts'o @ 2013-05-04 23:55 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-ext4
On Sat, May 04, 2013 at 01:05:54AM -0400, Mike Frysinger wrote:
> The ext2fs_test_block_bitmap_range2 func is not a void, so make sure we
> return a value. I picked EINVAL as it looks like what other things in
> this func use.
>
> URL: http://bugs.gentoo.org/467986
> Reported-by: Vicente Olivert Riera <vincent@gentoo.org>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This is already fixed in e2fsprogs's git repository, in commit
0d89e5acea9.
Cheers,
- Ted
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libext2fs: fix return value
2013-05-04 23:55 ` Theodore Ts'o
@ 2013-05-05 0:58 ` Mike Frysinger
2013-05-05 2:40 ` Andreas Dilger
0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2013-05-05 0:58 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-ext4
[-- Attachment #1: Type: Text/Plain, Size: 673 bytes --]
On Saturday 04 May 2013 19:55:03 Theodore Ts'o wrote:
> On Sat, May 04, 2013 at 01:05:54AM -0400, Mike Frysinger wrote:
> > The ext2fs_test_block_bitmap_range2 func is not a void, so make sure we
> > return a value. I picked EINVAL as it looks like what other things in
> > this func use.
> >
> > URL: http://bugs.gentoo.org/467986
> > Reported-by: Vicente Olivert Riera <vincent@gentoo.org>
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> This is already fixed in e2fsprogs's git repository, in commit
> 0d89e5acea9.
ok, the use of "master" and "next" is weird. i was using the normal "master"
branch which is apparently out of date.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libext2fs: fix return value
2013-05-05 0:58 ` Mike Frysinger
@ 2013-05-05 2:40 ` Andreas Dilger
2013-05-05 2:52 ` Theodore Ts'o
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Dilger @ 2013-05-05 2:40 UTC (permalink / raw)
To: Mike Frysinger; +Cc: Theodore Ts'o, linux-ext4@vger.kernel.org
On 2013-05-04, at 18:58, Mike Frysinger <vapier@gentoo.org> wrote:
> On Saturday 04 May 2013 19:55:03 Theodore Ts'o wrote:
>> On Sat, May 04, 2013 at 01:05:54AM -0400, Mike Frysinger wrote:
>>> The ext2fs_test_block_bitmap_range2 func is not a void, so make sure we
>>> return a value. I picked EINVAL as it looks like what other things in
>>> this func use.
>>>
>>> URL: http://bugs.gentoo.org/467986
>>> Reported-by: Vicente Olivert Riera <vincent@gentoo.org>
>>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>>
>> This is already fixed in e2fsprogs's git repository, in commit
>> 0d89e5acea9.
>
> ok, the use of "master" and "next" is weird. i was using the normal "master"
> branch which is apparently out of date.
I'd have to agree. It would be great if master was merged from maint more often so that patches would apply to either.
Cheers, Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libext2fs: fix return value
2013-05-05 2:40 ` Andreas Dilger
@ 2013-05-05 2:52 ` Theodore Ts'o
0 siblings, 0 replies; 5+ messages in thread
From: Theodore Ts'o @ 2013-05-05 2:52 UTC (permalink / raw)
To: Andreas Dilger; +Cc: Mike Frysinger, linux-ext4@vger.kernel.org
On Sat, May 04, 2013 at 08:40:21PM -0600, Andreas Dilger wrote:
> > ok, the use of "master" and "next" is weird. i was using the normal "master"
> > branch which is apparently out of date.
>
> I'd have to agree. It would be great if master was merged from maint more often so that patches would apply to either.
Sorry, I merge maint into next, but sometimes I forget to bump master
up.
Fixed now.
- Ted
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-05 2:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-04 5:05 [PATCH] libext2fs: fix return value Mike Frysinger
2013-05-04 23:55 ` Theodore Ts'o
2013-05-05 0:58 ` Mike Frysinger
2013-05-05 2:40 ` Andreas Dilger
2013-05-05 2:52 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).