* [PATCH] ext4: Fixed corruption when online resizing a fs with 1K block size
@ 2013-05-06 16:06 Maarten ter Huurne
2013-05-08 13:58 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Maarten ter Huurne @ 2013-05-06 16:06 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger
Cc: linux-ext4, linux-kernel, Maarten ter Huurne
Subtracting the number of the first data block places the superblock
backups one block too early, corrupting the file system. When the block
size is larger than 1K, the first data block is 0, so the subtraction
has no effect and no corruption occurs.
Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
---
fs/ext4/resize.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index c169477..116c80d 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1654,12 +1654,10 @@ errout:
err = err2;
if (!err) {
- ext4_fsblk_t first_block;
- first_block = ext4_group_first_block_no(sb, 0);
if (test_opt(sb, DEBUG))
printk(KERN_DEBUG "EXT4-fs: extended group to %llu "
"blocks\n", ext4_blocks_count(es));
- update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr - first_block,
+ update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr,
(char *)es, sizeof(struct ext4_super_block), 0);
}
return err;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: Fixed corruption when online resizing a fs with 1K block size
2013-05-06 16:06 [PATCH] ext4: Fixed corruption when online resizing a fs with 1K block size Maarten ter Huurne
@ 2013-05-08 13:58 ` Jan Kara
2013-06-17 13:07 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2013-05-08 13:58 UTC (permalink / raw)
To: Maarten ter Huurne
Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, linux-kernel
On Mon 06-05-13 18:06:07, Maarten ter Huurne wrote:
> Subtracting the number of the first data block places the superblock
> backups one block too early, corrupting the file system. When the block
> size is larger than 1K, the first data block is 0, so the subtraction
> has no effect and no corruption occurs.
Looking where mke2fs places backup super blocks you are right. You can
add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
>
> Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
> ---
> fs/ext4/resize.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
> index c169477..116c80d 100644
> --- a/fs/ext4/resize.c
> +++ b/fs/ext4/resize.c
> @@ -1654,12 +1654,10 @@ errout:
> err = err2;
>
> if (!err) {
> - ext4_fsblk_t first_block;
> - first_block = ext4_group_first_block_no(sb, 0);
> if (test_opt(sb, DEBUG))
> printk(KERN_DEBUG "EXT4-fs: extended group to %llu "
> "blocks\n", ext4_blocks_count(es));
> - update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr - first_block,
> + update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr,
> (char *)es, sizeof(struct ext4_super_block), 0);
> }
> return err;
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: Fixed corruption when online resizing a fs with 1K block size
2013-05-08 13:58 ` Jan Kara
@ 2013-06-17 13:07 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2013-06-17 13:07 UTC (permalink / raw)
To: Jan Kara; +Cc: Maarten ter Huurne, Andreas Dilger, linux-ext4, linux-kernel
On Wed, May 08, 2013 at 03:58:25PM +0200, Jan Kara wrote:
> On Mon 06-05-13 18:06:07, Maarten ter Huurne wrote:
> > Subtracting the number of the first data block places the superblock
> > backups one block too early, corrupting the file system. When the block
> > size is larger than 1K, the first data block is 0, so the subtraction
> > has no effect and no corruption occurs.
> Looking where mke2fs places backup super blocks you are right. You can
> add:
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-17 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 16:06 [PATCH] ext4: Fixed corruption when online resizing a fs with 1K block size Maarten ter Huurne
2013-05-08 13:58 ` Jan Kara
2013-06-17 13:07 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).