linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>, Jan Kara <jack@suse.cz>
Cc: Theodore Ts'o <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	spruce-project@linuxtesting.org
Subject: Re: [PATCH 0/2] ext4: deadlocks after allocation failure in ext4_init_io_end()
Date: Tue, 14 May 2013 15:06:28 +0800	[thread overview]
Message-ID: <20130514070627.GA3025@gmail.com> (raw)
In-Reply-To: <1368472093-16997-1-git-send-email-khoroshilov@ispras.ru>

On Mon, May 13, 2013 at 11:08:11PM +0400, Alexey Khoroshilov wrote:
> Hi, Ted!
> 
> Our tests for ext4 with targeted fault injection were stalled in Uninterruptible Sleep State 
> when they simulate a memory allocation failure in ext4_init_io_end() while it is called from 
> mpage_da_submit_io() or ext4_writepage().
> 
> It looks like the problems are that pages left locked after failure handling.
> 
> I am not completely sure that my patches take into account all required aspects, 
> but the tests are passed if the patches are applied.
> 
> Please find below syslog excerpt for the first issue.
> 
> Found by Linux File System Verification project (linuxtesting.org/spruce). 

Hi Alexey,

Thanks for fixing this.  The patch series looks good to me.  But the
commit (ext4: use io_end for multiple bios) has been reverted in dev
branch of ext4 tree.  I forward the mail to Jan to let him know your
fixes.

Regards,
                                                - Zheng

  parent reply	other threads:[~2013-05-14  7:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 19:08 [PATCH 0/2] ext4: deadlocks after allocation failure in ext4_init_io_end() Alexey Khoroshilov
2013-05-13 19:08 ` [PATCH 1/2] ext4: do not left pages locked in mpage_da_submit_io() Alexey Khoroshilov
2013-05-13 19:08 ` [PATCH 2/2] ext4: do not left pages locked in ext4_writepage() Alexey Khoroshilov
2013-05-14  7:06 ` Zheng Liu [this message]
2013-05-14 21:54 ` [PATCH 0/2] ext4: deadlocks after allocation failure in ext4_init_io_end() Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130514070627.GA3025@gmail.com \
    --to=gnehzuil.liu@gmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spruce-project@linuxtesting.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).