From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
Al Viro <viro@ZenIV.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v3] jbd2: Fix block tag checksum verification brokenness
Date: Tue, 28 May 2013 07:34:30 -0400 [thread overview]
Message-ID: <20130528113430.GC11839@thunk.org> (raw)
In-Reply-To: <20130513214750.GB8037@blackbox.djwong.org>
On Mon, May 13, 2013 at 02:47:50PM -0700, Darrick J. Wong wrote:
> Al Viro complained of a ton of bogosity with regards to the jbd2 block tag
> header checksum. This one checksum is 16 bits, so cut off the upper 16 bits
> and treat it as a 16-bit value and don't mess around with be32* conversions.
> Fortunately metadata checksumming is still "experimental" and not in a shipping
> e2fsprogs, so there should be few users affected by this.
>
> v2: Eliminate unnecessary variables and make it clear(er) which values are 32
> bits wide.
>
> v3: Add a comment about why we're only storing half of the crc32c.
>
> Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2013-05-28 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 23:38 [PATCH v2] jbd2: Fix block tag checksum verification brokenness Darrick J. Wong
2013-05-11 0:14 ` Al Viro
2013-05-11 5:18 ` Andreas Dilger
2013-05-13 21:47 ` [PATCH v3] " Darrick J. Wong
2013-05-28 11:34 ` Theodore Ts'o [this message]
[not found] <20130603021630.13790.qmail@science.horizon.com>
[not found] ` <20130603075521.GA6088@blackbox.djwong.org>
2013-06-04 0:40 ` Darrick J. Wong
2013-06-04 3:32 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528113430.GC11839@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).