From: Jan Kara <jack@suse.cz>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Jan Kara <jack@suse.cz>, xfs@oss.sgi.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] 285: Fix file syncing
Date: Thu, 30 May 2013 21:57:23 +0200 [thread overview]
Message-ID: <20130530195723.GB586@quack.suse.cz> (raw)
In-Reply-To: <51A75872.4080909@redhat.com>
On Thu 30-05-13 08:47:30, Eric Sandeen wrote:
> On 5/30/13 7:45 AM, Jan Kara wrote:
> > The intention of tests 08 and 09 in test generic/285 is to sync the
> > whole file before checking for data and holes. However the helper is
> > called with nbytes argument set to 0 which results in not syncing
> > anything. Set nbytes properly.
>
> Hm, are you sure? (Is the man page wrong, or is the sync_file_range
> implementation wrong?)
>
> DESCRIPTION
> sync_file_range() permits fine control when synchronizing the
> open file referred to by the file descriptor fd with disk.
>
> offset is the starting byte of the file range to be synchro-
> nized. nbytes specifies the length of the range to be synchro-
> nized, in bytes; if nbytes is zero, then all bytes from offset
> through to the end of file are synchronized.
My fault that I didn't read the manpage carefully enough. Scratch this
patch.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-05-30 19:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 12:45 [PATCH 1/3] 285: Fix test for ext4 in some configurations Jan Kara
2013-05-30 12:45 ` [PATCH 2/3] 285: Fix file syncing Jan Kara
2013-05-30 13:47 ` Eric Sandeen
2013-05-30 19:57 ` Jan Kara [this message]
2013-05-30 12:45 ` [PATCH 3/3] 285: Test offsets over 4GB Jan Kara
2013-05-30 13:48 ` Eric Sandeen
2013-05-30 20:01 ` Jan Kara
2013-05-30 20:05 ` Eric Sandeen
2013-05-30 20:49 ` Jan Kara
2013-05-30 22:34 ` Dave Chinner
2013-05-31 8:22 ` Jan Kara
2013-05-30 13:45 ` [PATCH 1/3] 285: Fix test for ext4 in some configurations Eric Sandeen
2013-05-30 22:30 ` Dave Chinner
2013-05-31 8:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530195723.GB586@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).