linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Ruslan Bilovol <ruslan.bilovol@ti.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: add sanity checks in __ext4_check_dir_entry
Date: Mon, 3 Jun 2013 11:40:48 -0400	[thread overview]
Message-ID: <20130603154048.GC20009@thunk.org> (raw)
In-Reply-To: <1370253616-8173-3-git-send-email-ruslan.bilovol@ti.com>

On Mon, Jun 03, 2013 at 01:00:16PM +0300, Ruslan Bilovol wrote:
> Added checks for NULL before dereferencing some pointers
> 
> +	if (!de || !bh || !dir)
> +		return 1;

Do you know which one of these pointers was NULL?

I want't make sure we're fixing the root issue as opposed to papering
over it.  I'm not seeing how any of these pointers could have been
NULL (at least in my upstream kernel), and while I believe that this
helped for your kernel, I want to make sure we understand exactly what
was going on.

Thanks,

					- Ted

  reply	other threads:[~2013-06-03 15:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 10:00 [PATCH 0/2] Misc ext4 fixes Ruslan Bilovol
2013-06-03 10:00 ` [PATCH 1/2] jbd2: check bh->b_data for NULL in jbd2_journal_get_descriptor_buffer before memset() Ruslan Bilovol
2013-06-03 15:33   ` Theodore Ts'o
2013-06-04 11:15     ` Ruslan Bilovol
2013-06-04 13:37       ` Theodore Ts'o
2013-06-06  8:02         ` Ruslan Bilovol
2013-06-03 10:00 ` [PATCH 2/2] ext4: add sanity checks in __ext4_check_dir_entry Ruslan Bilovol
2013-06-03 15:40   ` Theodore Ts'o [this message]
2013-06-04 11:17     ` Ruslan Bilovol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603154048.GC20009@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruslan.bilovol@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).