From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 23/26] ext4: Remove i_mutex from ext4_file_sync()
Date: Tue, 4 Jun 2013 14:40:52 -0400 [thread overview]
Message-ID: <20130604184052.GN3030@thunk.org> (raw)
In-Reply-To: <1369993379-13017-24-git-send-email-jack@suse.cz>
On Fri, May 31, 2013 at 11:42:56AM +0200, Jan Kara wrote:
> After removal of ext4_flush_unwritten_io() call, ext4_file_sync()
> doesn't need i_mutex anymore. Forcing of transaction commits doesn't
> need i_mutex as there's nothing inode specific in that code apart from
> grabbing transaction ids from the inode. So remove the lock.
>
> Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2013-06-04 18:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 9:42 [PATCH 00/22 v2] Fixes and improvements in ext4 writeback path Jan Kara
2013-05-31 9:42 ` [PATCH 01/26] ext4: use io_end for multiple bios Jan Kara
2013-06-04 16:03 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 02/26] jbd2: Don't create journal_head for temporary journal buffers Jan Kara
2013-06-04 16:04 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 03/26] jbd2: Remove journal_head from descriptor buffers Jan Kara
2013-06-04 16:06 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 04/26] jbd2: Refine waiting for shadow buffers Jan Kara
2013-06-04 16:09 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 05/26] jbd2: Remove outdated comment Jan Kara
2013-06-04 16:11 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 06/26] jbd2: Cleanup needed free block estimates when starting a transaction Jan Kara
2013-06-04 16:17 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 07/26] jbd2: Fix race in t_outstanding_credits update in jbd2_journal_extend() Jan Kara
2013-06-04 16:23 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 08/26] jbd2: Remove unused waitqueues Jan Kara
2013-06-04 16:24 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 09/26] jbd2: Transaction reservation support Jan Kara
2013-06-04 16:36 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 10/26] ext4: Provide wrappers for transaction reservation calls Jan Kara
2013-06-04 16:41 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 11/26] ext4: Stop messing with nr_to_write in ext4_da_writepages() Jan Kara
2013-06-04 16:49 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 12/26] ext4: Deprecate max_writeback_mb_bump sysfs attribute Jan Kara
2013-06-04 16:53 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 13/26] ext4: Improve writepage credit estimate for files with indirect blocks Jan Kara
2013-06-03 21:45 ` Darrick J. Wong
2013-06-04 16:57 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 14/26] ext4: Better estimate credits needed for ext4_da_writepages() Jan Kara
2013-06-04 17:01 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 15/26] ext4: Restructure writeback path Jan Kara
2013-06-04 17:18 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 16/26] ext4: Remove buffer_uninit handling Jan Kara
2013-06-04 17:20 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 17/26] ext4: Use transaction reservation for extent conversion in ext4_end_io Jan Kara
2013-06-04 17:29 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 18/26] ext4: Split extent conversion lists to reserved & unreserved parts Jan Kara
2013-06-04 18:22 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 19/26] ext4: Defer clearing of PageWriteback after extent conversion Jan Kara
2013-06-04 18:24 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 20/26] ext4: Protect extent conversion after DIO with i_dio_count Jan Kara
2013-06-04 18:28 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 21/26] ext4: Remove wait for unwritten extent conversion from ext4_truncate() Jan Kara
2013-06-04 18:30 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 22/26] ext4: Use generic_file_fsync() in ext4_file_fsync() in nojournal mode Jan Kara
2013-06-04 18:38 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 23/26] ext4: Remove i_mutex from ext4_file_sync() Jan Kara
2013-06-04 18:40 ` Theodore Ts'o [this message]
2013-05-31 9:42 ` [PATCH 24/26] ext4: Remove wait for unwritten extents in ext4_ind_direct_IO() Jan Kara
2013-06-04 18:42 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 25/26] ext4: Don't wait for extent conversion in ext4_punch_hole() Jan Kara
2013-06-04 18:46 ` Theodore Ts'o
2013-05-31 9:42 ` [PATCH 26/26] ext4: Remove ext4_ioend_wait() Jan Kara
2013-06-04 18:47 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604184052.GN3030@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).