From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH 3/3] ext4: Fix fsync error handling after filesystem abort.
Date: Wed, 12 Jun 2013 22:39:11 -0400 [thread overview]
Message-ID: <20130613023911.GB16959@thunk.org> (raw)
In-Reply-To: <1370882461-12786-3-git-send-email-dmonakhov@openvz.org>
On Mon, Jun 10, 2013 at 08:41:01PM +0400, Dmitry Monakhov wrote:
> If filesystem was aborted after inode's write back is complete
> but before its metadata was updated we may return success
> results in data loss.
> In order to handle fs abort correctly we have to check
> fs state once we discover that it is in MS_RDONLY state
>
> Test case: http://patchwork.ozlabs.org/patch/244297
>
> Changes from V2:
> - more spelling fixes
>
> Changes from V1:
> - fix spelling
>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Thanks, applied with Darrick's further suggested spelling fixes.
- Ted
next prev parent reply other threads:[~2013-06-13 2:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 16:40 [PATCH 1/3] jbd2: optimize jbd2_journal_force_commit V3 Dmitry Monakhov
2013-06-10 16:41 ` [PATCH 2/3] ext4: fix data integrity for ext4_sync_fs Dmitry Monakhov
2013-06-13 2:32 ` Theodore Ts'o
2013-06-10 16:41 ` [PATCH 3/3] ext4: Fix fsync error handling after filesystem abort Dmitry Monakhov
2013-06-10 21:22 ` Darrick J. Wong
2013-06-13 2:39 ` Theodore Ts'o [this message]
2013-06-13 0:42 ` [PATCH 1/3] jbd2: optimize jbd2_journal_force_commit V3 Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613023911.GB16959@thunk.org \
--to=tytso@mit.edu \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).