* [PATCH] jbd2: export __jbd2_debug for modular builds
@ 2013-06-13 13:45 Paul Gortmaker
2013-06-13 14:18 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2013-06-13 13:45 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-ext4, Paul Gortmaker
The commit "jbd2: use a single printk for jbd_debug()" introduced
a new function, __jbd2_debug. However it needs to be exported
or the final modpost stage of the build will fail with:
ERROR: "__jbd2_debug" [fs/ext4/ext4.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[Feel free to squash this into the original commit since it is
in your dev branch.]
fs/jbd2/journal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 331fd59..4c8b8d4 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -118,6 +118,7 @@ void __jbd2_debug(int level, const char *file, const char *func,
printk(KERN_DEBUG "%s: (%s, %u): %pV\n", file, func, line, &vaf);
va_end(args);
}
+EXPORT_SYMBOL(__jbd2_debug);
#endif
/* Checksumming functions */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] jbd2: export __jbd2_debug for modular builds
2013-06-13 13:45 [PATCH] jbd2: export __jbd2_debug for modular builds Paul Gortmaker
@ 2013-06-13 14:18 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-06-13 14:18 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-ext4
On Thu, Jun 13, 2013 at 09:45:30AM -0400, Paul Gortmaker wrote:
> The commit "jbd2: use a single printk for jbd_debug()" introduced
> a new function, __jbd2_debug. However it needs to be exported
> or the final modpost stage of the build will fail with:
>
> ERROR: "__jbd2_debug" [fs/ext4/ext4.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thanks, I've merged this into the original commit and pushed out an
updated dev branch.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-13 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-13 13:45 [PATCH] jbd2: export __jbd2_debug for modular builds Paul Gortmaker
2013-06-13 14:18 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).