From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] tests: clean up sed filtering of test output
Date: Sat, 15 Jun 2013 18:46:25 -0400 [thread overview]
Message-ID: <20130615224625.GA32754@thunk.org> (raw)
In-Reply-To: <1367281645-10595-1-git-send-email-adilger@dilger.ca>
On Mon, Apr 29, 2013 at 06:27:25PM -0600, Andreas Dilger wrote:
> The sed filters for test outputs that are used to remove build and
> test specific information (such as version strings, dates, times,
> UUIDs) were unconditionally deleting the first line of output. This
> would normally contain the tool version string, but in some cases
> contained other information that was being lost. This can lead to
> difficulty debugging test failures.
>
> The sed filtering has been changed to only remove the actual version
> strings. As well, similar filter strings were duplicated throughout
> many scripts, and "sed" and "tr" were often called multiple times in
> a pipeline. These have been consolidated into a single filter.sed
> file to avoid having to maintain these filters in multiple places.
>
> In a few cases, accidentally deleted messages have been restored to
> the expect output for the tests. In other cases, trivial whitespace
> has been changed in the expect files.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Applied, thanks.
- Ted
prev parent reply other threads:[~2013-06-15 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 0:27 [PATCH] tests: clean up sed filtering of test output Andreas Dilger
2013-04-30 0:35 ` Andreas Dilger
2013-06-15 22:46 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130615224625.GA32754@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).