From: Theodore Ts'o <tytso@mit.edu>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: liwang@ubuntukylin.com, adilger.kernel@dilger.ca,
yongjun_wei@trendmicro.com.cn, linux-ext4@vger.kernel.org
Subject: Re: [PATCH -next] ext4: fix missing unlock on error in ext4_punch_hole()
Date: Tue, 18 Jun 2013 11:05:28 -0400 [thread overview]
Message-ID: <20130618150528.GA7359@thunk.org> (raw)
In-Reply-To: <CAPgLHd-2_uHg9q_7nQway8uCigH=wgXxiGm9auYDNL_pByzJHA@mail.gmail.com>
On Tue, Jun 18, 2013 at 11:40:34AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock before return from function ext4_punch_hole()
> in the error handling case.
> Introduced by commit 1cdec9ca46c2c2a7ce452659f43dac64ad5fbc85.
> (ext4: Avoid unnecessarily writing back dirty pages before hole punching)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Hi Wei,
Thanks for pointing this out! I've folded this patch into the commit
"ext4: avoid unnecessarily writing back dirty pages before hole
punching".
- Ted
prev parent reply other threads:[~2013-06-18 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 3:40 [PATCH -next] ext4: fix missing unlock on error in ext4_punch_hole() Wei Yongjun
2013-06-18 15:05 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618150528.GA7359@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=liwang@ubuntukylin.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).