From: Theodore Ts'o <tytso@mit.edu>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [ext3,ext4] old bug in htree_dirblock_to_tree()
Date: Tue, 18 Jun 2013 12:01:20 -0400 [thread overview]
Message-ID: <20130618160120.GG7359@thunk.org> (raw)
In-Reply-To: <20130617152338.GS4165@ZenIV.linux.org.uk>
On Mon, Jun 17, 2013 at 04:23:38PM +0100, Al Viro wrote:
> Both ext3 and ext4 htree_dirblock_to_tree() is just filling
> the in-core rbtree for use by call_filldir(). All updates of
> ->f_pos are done by the latter; bumping it here (on error) is obviously
> wrong - we might very well have it nowhere near the block we'd found
> an error in.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Applied, thanks. Nice catch!
Jan, I'll carry the fix for ext3 as well in the ext4 tree, unless
you'd prefer otherwise.
- Ted
prev parent reply other threads:[~2013-06-18 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 15:23 [ext3,ext4] old bug in htree_dirblock_to_tree() Al Viro
2013-06-18 16:01 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618160120.GG7359@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).