From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Zheng Liu <wenqing.lz@taobao.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: signedness bug breaks ext4_inode_touch_time_cmp()
Date: Thu, 20 Jun 2013 23:21:58 +0800 [thread overview]
Message-ID: <20130620152158.GA20615@gmail.com> (raw)
In-Reply-To: <20130620080858.GA15095@elgon.mountain>
On Thu, Jun 20, 2013 at 11:08:58AM +0300, Dan Carpenter wrote:
> "diff" is unsigned so this doesn't sort the LRU list correctly.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for fixing it.
Regards,
- Zheng
> ---
> This was introduced in 6480bad916be "ext4: improve extent cache shrink
> mechanism to avoid to burn CPU time"
>
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index e0190f6..79e097d 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -880,7 +880,7 @@ static int ext4_inode_touch_time_cmp(void *priv, struct list_head *a,
> struct list_head *b)
> {
> struct ext4_inode_info *eia, *eib;
> - unsigned long diff;
> + long diff;
>
> eia = list_entry(a, struct ext4_inode_info, i_es_lru);
> eib = list_entry(b, struct ext4_inode_info, i_es_lru);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-06-20 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 8:08 [patch] ext4: signedness bug breaks ext4_inode_touch_time_cmp() Dan Carpenter
2013-06-20 14:13 ` Theodore Ts'o
2013-06-20 15:24 ` Zheng Liu
2013-06-20 15:21 ` Zheng Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620152158.GA20615@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).