From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Kazuya Mio <k-mio@sx.jp.nec.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on mounted device
Date: Thu, 27 Jun 2013 14:52:19 +0800 [thread overview]
Message-ID: <20130627065218.GA16789@gmail.com> (raw)
In-Reply-To: <51C7E72B.2070608@sx.jp.nec.com>
On Mon, Jun 24, 2013 at 03:28:59PM +0900, Kazuya Mio wrote:
> According to mke2fs man, we can create a filesystem on the mounted device
> when -FF option is specified.
> However, currently we have to specify -F option third to force mke2fs.
> This patch fixes the problem.
>
> Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
- Zheng
> ---
> misc/util.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/misc/util.c b/misc/util.c
> index 6c93e1c..40c8858 100644
> --- a/misc/util.c
> +++ b/misc/util.c
> @@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
> }
> if (mount_flags & EXT2_MF_MOUNTED) {
> fprintf(stderr, _("%s is mounted; "), device);
> - if (force > 2) {
> + if (force >= 2) {
> fputs(_("mke2fs forced anyway. Hope /etc/mtab is "
> "incorrect.\n"), stderr);
> return;
> @@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
> if (mount_flags & EXT2_MF_BUSY) {
> fprintf(stderr, _("%s is apparently in use by the system; "),
> device);
> - if (force > 2) {
> + if (force >= 2) {
> fputs(_("mke2fs forced anyway.\n"), stderr);
> return;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-27 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 6:28 [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on mounted device Kazuya Mio
2013-06-27 6:52 ` Zheng Liu [this message]
2013-06-27 9:05 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627065218.GA16789@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=adilger@dilger.ca \
--cc=k-mio@sx.jp.nec.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox