From: Theodore Ts'o <tytso@mit.edu>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: fs/ext4/inode.c::mpage_map_and_submit_extent - unused variable warning
Date: Sun, 7 Jul 2013 06:51:08 -0400 [thread overview]
Message-ID: <20130707105108.GA408@thunk.org> (raw)
In-Reply-To: <20130707115455.274b50dc@stein>
On Sun, Jul 07, 2013 at 11:54:55AM +0200, Stefan Richter wrote:
> Hi,
>
> gcc 4.6.3 says:
> fs/ext4/inode.c: In function ‘ext4_writepages’:
> fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized]
> fs/ext4/inode.c:2161:6: note: ‘err’ was declared here
>
> It would be an actual bug if mpage_map_and_submit_extent(handle, mpd, ...)
> can be called with mpd->map.m_len == 0. Can it?
It can't and we have a patch queued up to remove the warning.
Cheers,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-07-07 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 9:54 fs/ext4/inode.c::mpage_map_and_submit_extent - unused variable warning Stefan Richter
2013-07-07 10:51 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130707105108.GA408@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).