* fs/ext4/inode.c::mpage_map_and_submit_extent - unused variable warning
@ 2013-07-07 9:54 Stefan Richter
2013-07-07 10:51 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Richter @ 2013-07-07 9:54 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4
Hi,
gcc 4.6.3 says:
fs/ext4/inode.c: In function ‘ext4_writepages’:
fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized]
fs/ext4/inode.c:2161:6: note: ‘err’ was declared here
It would be an actual bug if mpage_map_and_submit_extent(handle, mpd, ...)
can be called with mpd->map.m_len == 0. Can it?
--
Stefan Richter
-=====-===-= -=== --===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: fs/ext4/inode.c::mpage_map_and_submit_extent - unused variable warning
2013-07-07 9:54 fs/ext4/inode.c::mpage_map_and_submit_extent - unused variable warning Stefan Richter
@ 2013-07-07 10:51 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-07-07 10:51 UTC (permalink / raw)
To: Stefan Richter; +Cc: Jan Kara, linux-ext4
On Sun, Jul 07, 2013 at 11:54:55AM +0200, Stefan Richter wrote:
> Hi,
>
> gcc 4.6.3 says:
> fs/ext4/inode.c: In function ‘ext4_writepages’:
> fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized]
> fs/ext4/inode.c:2161:6: note: ‘err’ was declared here
>
> It would be an actual bug if mpage_map_and_submit_extent(handle, mpd, ...)
> can be called with mpd->map.m_len == 0. Can it?
It can't and we have a patch queued up to remove the warning.
Cheers,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-07 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-07 9:54 fs/ext4/inode.c::mpage_map_and_submit_extent - unused variable warning Stefan Richter
2013-07-07 10:51 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).