From: Theodore Ts'o <tytso@mit.edu>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: linux-ext4@vger.kernel.org, dvhart@linux.intel.com,
darrick.wong@oracle.com
Subject: Re: [PATCH 1/2] debugfs.c: the max length of debugfs argument is too short
Date: Sun, 28 Jul 2013 22:37:56 -0400 [thread overview]
Message-ID: <20130729023756.GD5827@thunk.org> (raw)
In-Reply-To: <1374834657-17091-2-git-send-email-liezhi.yang@windriver.com>
On Fri, Jul 26, 2013 at 06:30:56PM +0800, Robert Yang wrote:
> The max length of debugfs argument is 256 which is too short, the
> arguments are two paths, the PATH_MAX is 4096 according to
> /usr/include/linux/limits.h, use 2048 (4096 / 2) is a reasonable value.
I'd just use BUFSIZ (which is 8192 on Linux systems). That's what the
ss library uses, and if you might have two paths and PATH_MAX is 4096,
2048 could easily be too small.
- Ted
next prev parent reply other threads:[~2013-07-29 3:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 10:30 [PATCH 0/2 V2] e2fsprogs/debugfs: do sparse copy when src is a sparse file Robert Yang
2013-07-26 10:30 ` [PATCH 1/2] debugfs.c: the max length of debugfs argument is too short Robert Yang
2013-07-29 2:37 ` Theodore Ts'o [this message]
2013-07-29 7:16 ` Robert Yang
2013-07-26 10:30 ` [PATCH 2/2] debugfs.c: do sparse copy when src is a sparse file Robert Yang
2013-07-26 16:02 ` Darrick J. Wong
2013-07-29 7:11 ` Robert Yang
-- strict thread matches above, loose matches on Subject: below --
2013-07-29 9:06 [PATCH 0/2 V3] e2fsprogs/debugfs: " Robert Yang
2013-07-29 9:06 ` [PATCH 1/2] debugfs.c: the max length of debugfs argument is too short Robert Yang
2013-07-19 2:17 [PATCH 0/2] e2fsprogs/debugfs: do sparse copy when src is a sparse file Robert Yang
2013-07-19 2:17 ` [PATCH 1/2] debugfs.c: the max length of debugfs argument is too short Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729023756.GD5827@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=dvhart@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).