From: Theodore Ts'o <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs: Don't report uninit extents past EOF invalid
Date: Tue, 13 Aug 2013 22:49:03 -0400 [thread overview]
Message-ID: <20130814024903.GB11064@thunk.org> (raw)
In-Reply-To: <20130813163112.GA4990@wallace>
On Tue, Aug 13, 2013 at 12:31:12PM -0400, Eric Whitney wrote:
> Clearly, I wasn't thinking about the ABI at all - thanks for pointing out
> that misstep.
>
> So, I'd like to withdraw that patch, please, and will post a V2 in a bit.
> Computing the eof_blk in that manner is better than an initial patch I had
> that worked but which was pretty ugly.
It didn't really make sense to put the eof_blk in the extent_info
structure, anyway, since it's not information about the that specific
extent. It's an inode-specific value which is set via:
handle->path[0].end_blk =
(EXT2_I_SIZE(handle->inode) + fs->blocksize - 1) >>
EXT2_BLOCK_SIZE_BITS(fs->super);
Right? So this is something you can calculate without making any
changes in lib/ext2fs/extent.c, unless I'm missing something.
- Ted
prev parent reply other threads:[~2013-08-14 2:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 20:28 [PATCH] e2fsprogs: Don't report uninit extents past EOF invalid Eric Whitney
2013-07-23 21:35 ` Eric Sandeen
2013-08-12 23:21 ` Eric Sandeen
2013-08-12 23:28 ` Eric Sandeen
2013-08-12 23:35 ` Eric Sandeen
2013-08-13 16:31 ` Eric Whitney
2013-08-14 2:49 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814024903.GB11064@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).