From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] ext4: isolate ext4_extents.h file
Date: Wed, 28 Aug 2013 14:49:56 -0400 [thread overview]
Message-ID: <20130828184956.GF27079@thunk.org> (raw)
In-Reply-To: <1377005893-4394-1-git-send-email-wenqing.lz@taobao.com>
On Tue, Aug 20, 2013 at 09:38:13PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> After applied the commit (4a092d73), we have reduced the number of
> source files that need to #include ext4_extents.h. But we can do
> better.
>
> This commit defines ext4_zeroout_es() in extents.c and move
> EXT_MAX_BLOCKS into ext4.h in order not to include ext4_extents.h in
> indirect.c and ioctl.c. Meanwhile we just need to include this file in
> extent_status.c when ES_AGGRESSIVE_TEST is defined. Otherwise, this
> commit removes a duplicated declaration in trace/events/ext4.h.
>
> After applied this patch, we just need to include ext4_extents.h file
> in {super,migrate,move_extents,extents}.c, and it is easy for us to
> define a new extent disk layout.
>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2013-08-28 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 13:38 [PATCH] ext4: isolate ext4_extents.h file Zheng Liu
2013-08-28 18:49 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828184956.GF27079@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).