From: Theodore Ts'o <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] Don't report uninit extents past EOF invalid
Date: Mon, 9 Sep 2013 10:53:41 -0400 [thread overview]
Message-ID: <20130909145341.GI6059@thunk.org> (raw)
In-Reply-To: <20130814183007.GB2602@wallace>
On Wed, Aug 14, 2013 at 02:30:07PM -0400, Eric Whitney wrote:
> Commit d3f32c2db8 introduced a regression that caused e2fsck failures
> in xfstests generic 013, 070, 083, 091, and 263. Uninitialized
> extents created by fallocate() at the end of file with the
> FALLOC_FL_KEEP_SIZE flag were identified as invalid. However,
> because the file size is not increased when FALLOC_FL_KEEP_SIZE is
> used, uninitialized extents can correctly contain blocks located past
> the end of file.
>
> Fix this by filtering out possible invalid extents if they are
> uninitialized and extend past the block containing the end of file.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2013-09-09 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 18:30 [PATCH v2] Don't report uninit extents past EOF invalid Eric Whitney
2013-09-09 14:53 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909145341.GI6059@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).