linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2image: Print a warning if running over a mounted filesystem
Date: Mon, 30 Sep 2013 16:19:48 -0400	[thread overview]
Message-ID: <20130930201948.GD5845@thunk.org> (raw)
In-Reply-To: <20130927004832.GA15078@orion.maiolino.org>

On Thu, Sep 26, 2013 at 09:48:33PM -0300, Carlos Maiolino wrote:
> 
> I'd suggest then to need a force when using -r or -q on a RW image. In case of a
> normal image, just a warning but continue.

(Sorry for not repsonding earlier; I was on vacation in at Yellowstone
/ Grand Teton National Park from Thursday through today.)

Yes, that's what I was suggesting.  Requiring force for the case of -r
or -q, but just a warning otherwise.

> Ted, as Eric said, I've got some useless images in the past too and just a
> warning won't really avoid the problem IMHO since, most of users don't even read
> what's being printed :-) so, request a force when getting at least a raw or
> QCOW2 image is very useful IMHO.

The useless images are primarily when we are trying to use -r or -q to
get the dynamic metadata (i.e., the directory blocks and extent tree
blocks).  That's what we generally need when are doing debugging, and
so yes, I'm fully in agreement with requiring force in the case of
e2image -r and e2image -q.

Regards,

					- Ted

  reply	other threads:[~2013-09-30 20:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 21:00 [PATCH] e2image: Print a warning if running over a mounted filesystem Carlos Maiolino
2013-09-26 22:12 ` Eric Sandeen
2013-09-26 23:56 ` Theodore Ts'o
2013-09-27  0:39   ` Eric Sandeen
2013-09-27  0:48     ` Carlos Maiolino
2013-09-30 20:19       ` Theodore Ts'o [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-09-27 19:01 Carlos Maiolino
2013-09-27 20:00 ` Carlos Maiolino
2013-09-30 20:24 ` Theodore Ts'o
2013-09-30 20:35   ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130930201948.GD5845@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).