From: Theodore Ts'o <tytso@mit.edu>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2image: Print a warning if running over a mounted filesystem
Date: Mon, 30 Sep 2013 16:24:39 -0400 [thread overview]
Message-ID: <20130930202439.GE5845@thunk.org> (raw)
In-Reply-To: <1380308495-3956-1-git-send-email-cmaiolino@redhat.com>
On Fri, Sep 27, 2013 at 04:01:35PM -0300, Carlos Maiolino wrote:
> Several users use to run e2image over a mounted RW filesystem, providing
> inconsistent, useless e2images for debugging purposes.
> This patch adds a warning in such cases, notifying the user and also adds a
> force option making e2image able to run in such cases.
> Also print a warning when not using qcow or raw formats but allows image
> creation to proceed, since, such images might be used for metadata backup
> purposes.
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
This looks good to me; go ahead and update the man page. :-)
- Ted
next prev parent reply other threads:[~2013-09-30 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 19:01 [PATCH] e2image: Print a warning if running over a mounted filesystem Carlos Maiolino
2013-09-27 20:00 ` Carlos Maiolino
2013-09-30 20:24 ` Theodore Ts'o [this message]
2013-09-30 20:35 ` Carlos Maiolino
-- strict thread matches above, loose matches on Subject: below --
2013-09-26 21:00 Carlos Maiolino
2013-09-26 22:12 ` Eric Sandeen
2013-09-26 23:56 ` Theodore Ts'o
2013-09-27 0:39 ` Eric Sandeen
2013-09-27 0:48 ` Carlos Maiolino
2013-09-30 20:19 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930202439.GE5845@thunk.org \
--to=tytso@mit.edu \
--cc=cmaiolino@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).