linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: tytso@mit.edu, darrick.wong@oracle.com
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 24/31] libext2fs: Use ext2fs_punch() to truncate quota file
Date: Mon, 30 Sep 2013 18:29:15 -0700	[thread overview]
Message-ID: <20131001012915.28415.89982.stgit@birch.djwong.org> (raw)
In-Reply-To: <20131001012642.28415.89353.stgit@birch.djwong.org>

Use the new ext2fs_punch() call to truncate the quota file.  This also
eliminates the need to fix it to work with bigalloc.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 lib/quota/quotaio.c |   19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)


diff --git a/lib/quota/quotaio.c b/lib/quota/quotaio.c
index 8ddb92a..807fabd 100644
--- a/lib/quota/quotaio.c
+++ b/lib/quota/quotaio.c
@@ -98,19 +98,6 @@ void update_grace_times(struct dquot *q)
 	}
 }
 
-static int release_blocks_proc(ext2_filsys fs, blk64_t *blocknr,
-			       e2_blkcnt_t blockcnt EXT2FS_ATTR((unused)),
-			       blk64_t ref_block EXT2FS_ATTR((unused)),
-			       int ref_offset EXT2FS_ATTR((unused)),
-			       void *private EXT2FS_ATTR((unused)))
-{
-	blk64_t	block;
-
-	block = *blocknr;
-	ext2fs_block_alloc_stats2(fs, block, -1);
-	return 0;
-}
-
 static int compute_num_blocks_proc(ext2_filsys fs, blk64_t *blocknr,
 			       e2_blkcnt_t blockcnt EXT2FS_ATTR((unused)),
 			       blk64_t ref_block EXT2FS_ATTR((unused)),
@@ -135,9 +122,9 @@ errcode_t quota_inode_truncate(ext2_filsys fs, ext2_ino_t ino)
 		inode.i_dtime = fs->now ? fs->now : time(0);
 		if (!ext2fs_inode_has_valid_blocks2(fs, &inode))
 			return 0;

  parent reply	other threads:[~2013-10-01  1:29 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01  1:26 [PATCH v1 00/31] e2fsprogs September 2013 patchbomb Darrick J. Wong
2013-10-01  1:26 ` [PATCH 01/31] tune2fs: Don't convert block # to cluster # when clearing uninit_bg Darrick J. Wong
2013-10-03 16:53   ` Lukáš Czerner
2013-10-03 19:04     ` Darrick J. Wong
2013-10-07 12:49       ` Lukáš Czerner
2013-10-07 13:03       ` Theodore Ts'o
2013-10-09 22:10         ` Darrick J. Wong
2013-10-10  0:26           ` Theodore Ts'o
2013-10-10 22:04             ` Darrick J. Wong
2013-10-13  3:09   ` Theodore Ts'o
2013-10-01  1:26 ` [PATCH 02/31] libext2fs: Only link an inode into a directory once Darrick J. Wong
2013-10-01 15:37   ` jon ernst
2013-10-01 21:11     ` Darrick J. Wong
2013-10-07 13:17   ` Theodore Ts'o
2013-10-07 18:53     ` Darrick J. Wong
2013-10-01  1:27 ` [PATCH 03/31] Define an error code for block bitmap checksum failures Darrick J. Wong
2013-10-13  3:12   ` Theodore Ts'o
2013-10-01  1:27 ` [PATCH 04/31] libext2fs: Fix a minor grammatical error in the error catalog Darrick J. Wong
2013-10-07 13:20   ` Theodore Ts'o
2013-10-01  1:27 ` [PATCH 05/31] libext2fs: Add space for metadata checksum when unconverting a hashed directory block Darrick J. Wong
2013-10-13  3:16   ` Theodore Ts'o
2013-10-01  1:27 ` [PATCH 06/31] e2p: Fix f[gs]etflags argument size mismatch Darrick J. Wong
2013-10-07 13:33   ` Theodore Ts'o
2013-10-07 20:40     ` Darrick J. Wong
2013-10-07 23:23       ` Darrick J. Wong
2013-10-08  0:06         ` Theodore Ts'o
2013-10-08  0:28           ` Darrick J. Wong
2013-10-01  1:27 ` [PATCH 07/31] libext2fs: When writing a file that has a i_size > 2GB, set the large_file feature flag and update the superblock Darrick J. Wong
2013-10-07 13:14   ` Theodore Ts'o
2013-10-01  1:27 ` [PATCH 08/31] libext2fs: Fix off-by-one error in file truncation Darrick J. Wong
2013-10-07 14:02   ` Lukáš Czerner
2013-10-08 15:52   ` Theodore Ts'o
2013-10-01  1:27 ` [PATCH 09/31] libext2fs: Rewind extent pointer when totally deleting an extent Darrick J. Wong
2013-10-07 13:37   ` Theodore Ts'o
2013-10-07 18:24     ` Darrick J. Wong
2013-10-01  1:27 ` [PATCH 10/31] libext2fs: Allow callers to punch a single block Darrick J. Wong
2013-10-01 19:09   ` jon ernst
2013-10-01 21:25     ` Darrick J. Wong
2013-10-07 13:40   ` Theodore Ts'o
2013-10-08 15:54   ` Theodore Ts'o
2013-10-01  1:27 ` [PATCH 11/31] libext2fs: ind_punch() must not stop examining blocks prematurely Darrick J. Wong
2013-10-07 13:43   ` Theodore Ts'o
2013-10-01  1:27 ` [PATCH 12/31] e2fsprogs: Fix blk_t <- blk64_t assignment mismatches Darrick J. Wong
2013-10-07 13:52   ` Theodore Ts'o
2013-10-01  1:28 ` [PATCH 13/31] e2fsprogs: Less critical fixes to use the appropriate blk*t types Darrick J. Wong
2013-10-07 13:59   ` Theodore Ts'o
2013-10-01  1:28 ` [PATCH 14/31] libext2fs: Fix ext2fs_open2() truncation of the superblock parameter Darrick J. Wong
2013-10-07 14:30   ` Lukáš Czerner
2013-10-07 18:42     ` Darrick J. Wong
2013-10-08 15:58   ` Theodore Ts'o
2013-10-08 17:47     ` Darrick J. Wong
2013-10-01  1:28 ` [PATCH 15/31] e2fsck: Teach EA refcounting code to handle 48bit block addresses Darrick J. Wong
2013-10-07 15:30   ` Lukáš Czerner
2013-10-07 18:37     ` Darrick J. Wong
2013-10-08 16:01       ` Theodore Ts'o
2013-10-09 21:53         ` Darrick J. Wong
2013-10-01  1:28 ` [PATCH 16/31] debugfs: Handle 64bit block numbers Darrick J. Wong
2013-10-07 15:49   ` Lukáš Czerner
2013-10-07 18:49     ` Darrick J. Wong
2013-10-01  1:28 ` [PATCH 17/31] libext2fs: Refactor u32-list to handle 32 and 64-bit data types Darrick J. Wong
2013-10-10 14:46   ` Lukáš Czerner
2013-10-10 18:05     ` Darrick J. Wong
2013-10-01  1:28 ` [PATCH 18/31] libext2fs: Badblocks should handle 48-bit block numbers correctly Darrick J. Wong
2013-10-08 16:03   ` Theodore Ts'o
2013-10-09 21:57     ` Darrick J. Wong
2013-10-01  1:28 ` [PATCH 19/31] badblocks: Use the new badblocks APIs for 64-bit block numbers Darrick J. Wong
2013-10-10 15:01   ` Lukáš Czerner
2013-10-01  1:28 ` [PATCH 20/31] e2fsprogs: Add (optional) sparse checking to the build Darrick J. Wong
2013-10-12  3:13   ` Theodore Ts'o
2013-10-01  1:28 ` [PATCH 21/31] libext2fs: Be more thorough in searching a range of blocks for a cluster Darrick J. Wong
2013-10-08 16:09   ` Theodore Ts'o
2013-10-01  1:29 ` [PATCH 22/31] libext2fs: During punch, only free a cluster if we're sure that all blocks in the cluster are being punched Darrick J. Wong
2013-10-10 15:53   ` Lukáš Czerner
2013-10-10 19:29     ` Darrick J. Wong
2013-10-01  1:29 ` [PATCH 23/31] libext2fs: expanddir and mkjournal need not update the summary counts when performing an implied cluster allocation Darrick J. Wong
2013-10-10 16:02   ` Lukáš Czerner
2013-10-01  1:29 ` Darrick J. Wong [this message]
2013-10-10 16:06   ` [PATCH 24/31] libext2fs: Use ext2fs_punch() to truncate quota file Lukáš Czerner
2013-10-01  1:29 ` [PATCH 25/31] e2fsck: Only release clusters when shortening a directory during a rehash Darrick J. Wong
2013-10-10 16:13   ` Lukáš Czerner
2013-10-01  1:29 ` [PATCH 26/31] libext2fs: openfs() musn't allow bigalloc without EXT2_FLAGS_64BITS Darrick J. Wong
2013-10-07 12:50   ` Lukáš Czerner
2013-10-12  1:36     ` Theodore Ts'o
2013-10-01  1:29 ` [PATCH 27/31] resize2fs: Convert fs to and from 64bit mode Darrick J. Wong
2013-10-01  1:29 ` [PATCH 28/31] mke2fs: Complain about creating 64bit filesystems without extents Darrick J. Wong
2013-10-12  1:14   ` Theodore Ts'o
2013-10-01  1:29 ` [PATCH 29/31] e2fsck: Enable extents on all 64bit filesystems Darrick J. Wong
2013-10-12  1:19   ` Theodore Ts'o
2013-10-01  1:29 ` [PATCH 30/31] libext2fs: Support modifying arbitrary extended attributes Darrick J. Wong
2013-10-01  1:30 ` [PATCH 31/31] misc: Add fuse2fs, a FUSE server for e2fsprogs Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131001012915.28415.89982.stgit@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).