From: Theodore Ts'o <tytso@mit.edu>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: linux-ext4@vger.kernel.org, dvhart@linux.intel.com,
darrick.wong@oracle.com
Subject: Re: [PATCH 2/3 V4] debugfs.c: do sparse copy when src is a sparse file
Date: Sun, 13 Oct 2013 22:49:52 -0400 [thread overview]
Message-ID: <20131014024952.GD9609@thunk.org> (raw)
In-Reply-To: <1377498124-25842-3-git-send-email-liezhi.yang@windriver.com>
On Mon, Aug 26, 2013 at 02:22:03PM +0800, Robert Yang wrote:
> Let debugfs do sparse copy when src is a sparse file, just like
> "cp --sparse=auto"
>
> * For the:
> #define IO_BUFSIZE 64*1024
> this is a suggested value from gnu coreutils:
> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/ioblksize.h;h=1ae93255e7d0ccf0855208c7ae5888209997bf16;hb=HEAD
>
> * Use malloc() to allocate memory for the buffer since put 64K (or
> more) on the stack seems not a good idea.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> Acked-by: Darren Hart <dvhart@linux.intel.com>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2013-10-14 2:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 6:22 [PATCH 0/3 V4] e2fsprogs/debugfs: do sparse copy when src is a sparse file Robert Yang
2013-08-26 6:22 ` [PATCH 1/3 V4] debugfs.c: the max length of debugfs argument is too short Robert Yang
2013-10-14 2:49 ` Theodore Ts'o
2013-08-26 6:22 ` [PATCH 2/3 V4] debugfs.c: do sparse copy when src is a sparse file Robert Yang
2013-10-14 2:49 ` Theodore Ts'o [this message]
2013-10-15 3:10 ` Darrick J. Wong
2013-10-15 4:52 ` Robert Yang
2013-08-26 6:22 ` [PATCH 3/3 V4] contrib/populate-extfs.sh: use debugfs to populate extX fs Robert Yang
2013-10-14 2:50 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014024952.GD9609@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=dvhart@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).