From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Eryu Guan <guaneryu@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: don't cache out of order extents
Date: Thu, 17 Oct 2013 10:40:44 -0400 [thread overview]
Message-ID: <20131017144044.GA3605@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1310171534440.3212@localhost.localdomain>
On Thu, Oct 17, 2013 at 03:44:35PM +0200, Lukáš Czerner wrote:
>
> So what will happen with the file system with this patch when
> presented with such corruption ?
>
> It seems to me that ext4_es_cache_extent() will happily skip this
> extent because it will find that this particular offset is already
> in the tree. Hence we'll have a gap in the status tree which really
> should not be there and I suspect that something bad will happen.
Ah, I see what's going wrong. __read_extent_tree_block() calls
__ext4_ext_check() which is supposed to validate that extent tree
block is valid. The __ext4_ext_check() function calls
ext4_valid_extent_entries() which is supposed to validate the
individual entries in the extent. However, it is not checking to make
sure there are no overlapping extents. We should add that check to
ext4_valid_extent_entries(); that way, we will call ext4_error_inode()
to mark the file system as corrupted.
Eryu's patch, or something like it, will still be needed so that in
the case of errors=countinue, we don't end up calling BUG_ON().
Thanks for finding this!
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-17 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 9:27 [PATCH] ext4: don't cache out of order extents Eryu Guan
2013-10-17 13:44 ` Lukáš Czerner
2013-10-17 14:40 ` Theodore Ts'o [this message]
2013-10-17 15:22 ` Lukáš Czerner
2013-10-17 15:58 ` Theodore Ts'o
2013-10-17 15:06 ` Eryu Guan
2013-10-20 13:27 ` [PATCH v2] ext4: check for overlapping extents in ext4_valid_extent_entries() Eryu Guan
2013-10-21 11:59 ` Eryu Guan
2013-10-21 12:47 ` Eryu Guan
2013-10-21 16:06 ` Lukáš Czerner
2013-10-22 18:40 ` Eryu Guan
2013-12-04 2:36 ` [PATCH v3] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017144044.GA3605@thunk.org \
--to=tytso@mit.edu \
--cc=guaneryu@gmail.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).