From: Jan Kara <jack@suse.cz>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Jan Kara <jack@suse.cz>,
stable@vger.kernel.org, Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org
Subject: Re: Commit 7d7345322d60edb0fa49a64a89b31360f01d09cb
Date: Wed, 23 Oct 2013 16:09:29 +0200 [thread overview]
Message-ID: <20131023140929.GA6431@quack.suse.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.1310231404560.1918@localhost.localdomain>
On Wed 23-10-13 14:11:50, Lukáš Czerner wrote:
> On Wed, 23 Oct 2013, Jan Kara wrote:
>
> > Date: Wed, 23 Oct 2013 12:38:55 +0200
> > From: Jan Kara <jack@suse.cz>
> > To: stable@vger.kernel.org
> > Cc: Ted Tso <tytso@mit.edu>, linux-ext4@vger.kernel.org
> > Subject: Commit 7d7345322d60edb0fa49a64a89b31360f01d09cb
> >
> > Hello,
> >
> > can you please consider commit 7d7345322d60edb0fa49a64a89b31360f01d09cb "ext4: fix warning in
> > ext4_da_update_reserve_space()" for -stable kernels (3.10 & 3.11 would make
> > sense). Although the problem mostly results only in a warning, it can cause
> > fs corruption in the rare case of hitting ENOSPC at the wrong moment.
>
> I am not sure about that. First of all we would have to consider
> commit 1c8924eb106c1ac755d5d35ce9b3ff42e89e2511 as well since you
> make a use of the function introduced in that commit.
Right, I forgot about that.
> Also it's quite big change to be pushed to stable. However I think
> that the warning is actually mostly harmless since we have
>
> 27dd43854227bb0e6ab70129bd21b60d396db2e7 ext4: introduce reserved
> space
>
>
> so If I am not missing something, then chances that we'll end up with
> no space to allocate metadata blocks from are very very low.
OK, right. The reserved metadata blocks patch is going to make the real
failure even more unlikely. So you are right we probably don't need the
patch in stable after all. I'm withdrawing my request. Thanks for having a
look.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2013-10-23 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 10:38 Commit 7d7345322d60edb0fa49a64a89b31360f01d09cb Jan Kara
2013-10-23 12:11 ` Lukáš Czerner
2013-10-23 14:09 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023140929.GA6431@quack.suse.cz \
--to=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).