From: Theodore Ts'o <tytso@mit.edu>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs: fix build w/o quota
Date: Wed, 23 Oct 2013 11:22:51 -0400 [thread overview]
Message-ID: <20131023152251.GC21448@thunk.org> (raw)
In-Reply-To: <20131023125147.GA31449@orion.maiolino.org>
On Wed, Oct 23, 2013 at 10:51:48AM -0200, Carlos Maiolino wrote:
> Hey Eric,
>
> I did a test here building the e2fsprogs -next tree without quota support and I
> didn't have any problems configuring and compiling it. Can you share the test
> you did and failed?
>
I've been able to replicate the problem. You may need to rm -rf your
build directory and then run from scratch to see it.
Sorry for not responding sooner; I'm in Edinburgh this week and in
conference mode.
The reason why we have continud building libquota even when libsupport
is not defined is because the plan is to rename libquota to libsupport
once 1.42.x is released. Libquota/libsupport is desinged to never be
built as a shared library, and the idea is to move things like
e2fsck/profile.c which is used by e2fsck and mke2fs, into libsupport.
The rational for that is that the functions in libquota are already
horribly e2fsprogs specific and aren't really set up to be usable as a
generic quota support library. So we might as well make it be a
standardized place for internal support functions used by multiple
e2fsprogs programs.
I'll try to find a fix that minimizes deltas between the maint branch
and the next branch.
Cheers,
- Ted
next prev parent reply other threads:[~2013-10-23 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 16:07 [PATCH] e2fsprogs: fix build w/o quota Eric Sandeen
2013-10-22 17:46 ` Eric Sandeen
2013-10-23 12:51 ` Carlos Maiolino
2013-10-23 15:22 ` Theodore Ts'o [this message]
2013-10-23 16:29 ` Eric Sandeen
2013-10-23 16:53 ` [PATCH] Fix noquota build Theodore Ts'o
2013-10-23 16:55 ` Eric Sandeen
2013-10-24 0:41 ` Theodore Ts'o
2013-10-24 13:20 ` [PATCH] e2fsprogs: fix build w/o quota Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023152251.GC21448@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).