From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix FITRIM in no journal mode
Date: Wed, 30 Oct 2013 11:12:01 -0400 [thread overview]
Message-ID: <20131030151201.GA13343@thunk.org> (raw)
In-Reply-To: <1380102385-10475-1-git-send-email-lczerner@redhat.com>
On Wed, Sep 25, 2013 at 11:46:25AM +0200, Lukas Czerner wrote:
> When using FITRIM ioctl on a file system without journal it will
> only trim the block group once, no matter how many times you invoke
> FITRIM ioctl and how many block you release from the block group.
>
> It is because we only clear EXT4_GROUP_INFO_WAS_TRIMMED_BIT in journal
> callback. Fix this by clearing the bit in no journal mode as well.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Reported-by: Jorge Fábregas <jorge.fabregas@gmail.com>
Applied, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-10-30 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 9:46 [PATCH] ext4: fix FITRIM in no journal mode Lukas Czerner
2013-10-30 15:12 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030151201.GA13343@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).