From: Andrew Morton <akpm@linux-foundation.org>
To: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
EXT4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] rbtree/test: test rbtree_postorder_for_each_entry_safe()
Date: Wed, 6 Nov 2013 15:16:04 -0800 [thread overview]
Message-ID: <20131106151604.c2f85c3463e663cc27fd4eaf@linux-foundation.org> (raw)
In-Reply-To: <1383773843-19981-1-git-send-email-cody@linux.vnet.ibm.com>
On Wed, 6 Nov 2013 13:37:23 -0800 Cody P Schafer <cody@linux.vnet.ibm.com> wrote:
> ...
>
> --- a/lib/rbtree_test.c
> +++ b/lib/rbtree_test.c
> @@ -114,6 +114,16 @@ static int black_path_count(struct rb_node *rb)
> return count;
> }
>
> +static void check_postorder_foreach(int nr_nodes)
> +{
> + struct test_node *cur, *n;
> + int count = 0;
> + rbtree_postorder_for_each_entry_safe(cur, n, &root, rb)
> + count++;
> +
> + WARN_ON_ONCE(count != nr_nodes);
> +}
> +
> static void check_postorder(int nr_nodes)
> {
> struct rb_node *rb;
> @@ -148,6 +158,7 @@ static void check(int nr_nodes)
> WARN_ON_ONCE(count < (1 << black_path_count(rb_last(&root))) - 1);
>
> check_postorder(nr_nodes);
> + check_postorder_foreach(nr_nodes);
> }
>
> static void check_augmented(int nr_nodes)
I'm rather confused about where this fits with the other (and
apparently withdrawn) patches.
Please resend everything?
prev parent reply other threads:[~2013-11-06 23:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383345566-25087-1-git-send-email-cody@linux.vnet.ibm.com>
2013-11-01 22:38 ` [PATCH 4/8] fs/ext4: use rbtree postorder iteration helper instead of opencoding Cody P Schafer
2013-11-01 22:38 ` [PATCH 6/8] fs/ext3: " Cody P Schafer
2013-11-04 14:26 ` Jan Kara
2013-11-05 0:45 ` Jan Kara
2013-11-05 1:33 ` Cody P Schafer
2013-11-05 1:40 ` [PATCH 1/2] rbtree: fix postorder iteration when the rb_node is not the first element in an entry Cody P Schafer
2013-11-05 1:40 ` [PATCH 2/2] rbtree/test: move rb_node to the middle of the test struct Cody P Schafer
2013-11-05 10:05 ` [PATCH 1/2] rbtree: fix postorder iteration when the rb_node is not the first element in an entry Cody P Schafer
2013-11-05 21:57 ` Jan Kara
2013-11-05 22:56 ` Jan Kara
2013-11-06 20:18 ` Cody P Schafer
2013-11-06 21:37 ` [PATCH] rbtree/test: test rbtree_postorder_for_each_entry_safe() Cody P Schafer
2013-11-06 23:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106151604.c2f85c3463e663cc27fd4eaf@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adilger.kernel@dilger.ca \
--cc=cody@linux.vnet.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).