From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: remove unreachable code in ext4_can_extents_be_merged()
Date: Thu, 7 Nov 2013 22:26:00 -0500 [thread overview]
Message-ID: <20131108032600.GA11668@thunk.org> (raw)
In-Reply-To: <5272C4E3.5040206@redhat.com>
On Thu, Oct 31, 2013 at 04:00:19PM -0500, Eric Sandeen wrote:
> commit
> ec22ba8e ext4: disable merging of uninitialized extents
>
> ensured that if either extent under consideration is uninit,
> we decline to merge, and immediately return.
>
> But right after that test, we test again for an uninit
> extent; we can never hit this. So just remove the impossible
> test and associated variable.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied
- Ted
prev parent reply other threads:[~2013-11-08 3:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 21:00 [PATCH] ext4: remove unreachable code in ext4_can_extents_be_merged() Eric Sandeen
2013-10-31 21:18 ` [PATCH] ext4: remove unreachable code after ext4_can_extents_be_merged() Eric Sandeen
2013-11-01 3:09 ` Zheng Liu
2013-11-08 3:26 ` Theodore Ts'o
2013-11-01 3:05 ` [PATCH] ext4: remove unreachable code in ext4_can_extents_be_merged() Zheng Liu
2013-11-08 3:26 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108032600.GA11668@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).