From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <andreas.dilger@intel.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: return non-zero st_blocks for inline data
Date: Thu, 7 Nov 2013 22:45:04 -0500 [thread overview]
Message-ID: <20131108034504.GC11668@thunk.org> (raw)
In-Reply-To: <1383734552-12991-1-git-send-email-andreas.dilger@intel.com>
On Wed, Nov 06, 2013 at 03:42:32AM -0700, Andreas Dilger wrote:
> @@ -4542,9 +4551,9 @@ int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry,
> * blocks for this file.
> */
> delalloc_blocks = EXT4_C2B(EXT4_SB(inode->i_sb),
> - EXT4_I(inode)->i_reserved_data_blocks);
> + EXT4_I(inode)->i_reserved_data_blocks);
> + stat->blocks += delalloc_blocks << (inode->i_sb->s_blocksize_bits - 9);
>
> - stat->blocks += (delalloc_blocks << inode->i_sb->s_blocksize_bits)>>9;
Why this change to the calculation to stat->blocks?
- Ted
next prev parent reply other threads:[~2013-11-08 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 10:42 [PATCH] ext4: return non-zero st_blocks for inline data Andreas Dilger
2013-11-08 3:45 ` Theodore Ts'o [this message]
2013-11-08 12:25 ` Dilger, Andreas
2013-11-12 3:44 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108034504.GC11668@thunk.org \
--to=tytso@mit.edu \
--cc=andreas.dilger@intel.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).