linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libext2fs: fix printf conversion spec in tst_iscan.c
@ 2013-11-11 19:32 Eric Whitney
  2013-12-03  4:37 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Whitney @ 2013-11-11 19:32 UTC (permalink / raw)
  To: linux-ext4; +Cc: tytso

A recent patch to fix blk_t to blk64_t assignment mismatches in
e2fsprogs (commit 4dbfd79d1458ce1259b951377e341aeb6197f8c1) created
a printf conversion spec / argument type mismatch in tst_iscan.c.
Fix this to avoid truncation of the printed value and to silence
a compiler warning seen when "make check" is run.

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
 lib/ext2fs/tst_iscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ext2fs/tst_iscan.c b/lib/ext2fs/tst_iscan.c
index a95296c..70bfbec 100644
--- a/lib/ext2fs/tst_iscan.c
+++ b/lib/ext2fs/tst_iscan.c
@@ -182,7 +182,7 @@ static void check_map(void)
 
 	for (i=0; test_vec[i]; i++) {
 		if (ext2fs_test_block_bitmap2(touched_map, test_vec[i])) {
-			printf("Bad block was touched --- %u\n", test_vec[i]);
+			printf("Bad block was touched --- %llu\n", test_vec[i]);
 			failed++;
 			first_no_comma = 1;
 		}
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] libext2fs: fix printf conversion spec in tst_iscan.c
  2013-11-11 19:32 [PATCH] libext2fs: fix printf conversion spec in tst_iscan.c Eric Whitney
@ 2013-12-03  4:37 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-12-03  4:37 UTC (permalink / raw)
  To: Eric Whitney; +Cc: linux-ext4

On Mon, Nov 11, 2013 at 02:32:13PM -0500, Eric Whitney wrote:
> A recent patch to fix blk_t to blk64_t assignment mismatches in
> e2fsprogs (commit 4dbfd79d1458ce1259b951377e341aeb6197f8c1) created
> a printf conversion spec / argument type mismatch in tst_iscan.c.
> Fix this to avoid truncation of the printed value and to silence
> a compiler warning seen when "make check" is run.
> 
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>

Thanks, applied.

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-03  4:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11 19:32 [PATCH] libext2fs: fix printf conversion spec in tst_iscan.c Eric Whitney
2013-12-03  4:37 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).