From: Theodore Ts'o <tytso@mit.edu>
To: Kit Westneat <kwestneat@ddn.com>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"Dilger, Andreas" <andreas.dilger@intel.com>
Subject: Re: [PATCH] e2image: double free when restoring image
Date: Mon, 2 Dec 2013 13:03:37 -0500 [thread overview]
Message-ID: <20131202180337.GA6200@thunk.org> (raw)
In-Reply-To: <529664F6.3040103@ddn.com>
On Wed, Nov 27, 2013 at 04:32:38PM -0500, Kit Westneat wrote:
> Hello,
>
> I've been running into a double free when trying to apply an e2image to a
> loopback device:
It looks like there are a number of memory pointer overruns which
valgrind is finding, not just the one you have pointed out. Thanks
for pointing out this issue.
For this particular case, it's probably better to set
new_io->block_size to fs->blocksize; I'll send out some patches to fix
these issues, and very clearly we need to add some regression tests to
catch these in the future.
Thanks,
- Ted
prev parent reply other threads:[~2013-12-02 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 21:32 [PATCH] e2image: double free when restoring image Kit Westneat
2013-11-29 17:45 ` Dilger, Andreas
2013-12-02 17:27 ` Kit Westneat
2013-12-02 18:26 ` Theodore Ts'o
2013-12-02 19:55 ` [PATCH 1/3] e2image: pass the correct size write_header Theodore Ts'o
2013-12-02 19:55 ` [PATCH 2/3] libext2fs: set the fs block size to new_io in ext2fs_rewrite_to_io() Theodore Ts'o
2013-12-02 19:55 ` [PATCH 3/3] libext2fs: fix some memory leaks with image file handling Theodore Ts'o
2013-12-02 18:03 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202180337.GA6200@thunk.org \
--to=tytso@mit.edu \
--cc=andreas.dilger@intel.com \
--cc=kwestneat@ddn.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).