From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zheng Liu Subject: Re: [PATCH v2 19/28] mke2fs: add inline_data support in mke2fs Date: Wed, 4 Dec 2013 11:27:57 +0800 Message-ID: <20131204032757.GB11238@gmail.com> References: <1386072715-9869-1-git-send-email-wenqing.lz@taobao.com> <1386072715-9869-20-git-send-email-wenqing.lz@taobao.com> <20131203223026.GI9535@birch.djwong.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org, Theodore Ts'o , Zheng Liu To: "Darrick J. Wong" Return-path: Received: from mail-pd0-f177.google.com ([209.85.192.177]:61357 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314Ab3LDDZA (ORCPT ); Tue, 3 Dec 2013 22:25:00 -0500 Received: by mail-pd0-f177.google.com with SMTP id q10so21430183pdj.36 for ; Tue, 03 Dec 2013 19:25:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131203223026.GI9535@birch.djwong.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, Dec 03, 2013 at 02:30:26PM -0800, Darrick J. Wong wrote: [...] > > + * notify users that inline data will never be useful. > > + */ > > + if ((fs_param.s_feature_incompat & > > + EXT4_FEATURE_INCOMPAT_INLINE_DATA) && > > + inode_size == EXT2_GOOD_OLD_INODE_SIZE) { > > Perhaps I'm missing something here, but why is it impossible to use i_blocks > for inline data even if there's no space for EAs? If I understand correctly, on kernel side, we determine an inode has inline data according to whether we have 'system.data' xattr entry on inode extended attribute space. If an inode doesn't have enough space to store an entry with 'system.data', we just think this inode doesn't has inline data. So that is why I add this sanity check. Regards, - Zheng