From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota_write()
Date: Wed, 4 Dec 2013 03:01:41 -0800 [thread overview]
Message-ID: <20131204110141.GB3263@infradead.org> (raw)
In-Reply-To: <1386071825-10915-1-git-send-email-jack@suse.cz>
On Tue, Dec 03, 2013 at 12:57:05PM +0100, Jan Kara wrote:
> ext2_quota_write() doesn't properly setup bh it passes to
> ext2_get_block() and thus we hit assertion BUG_ON(maxblocks == 0) in
> ext2_get_blocks() (or we could actually ask for mapping arbitrary number
> of blocks depending on whatever value was on stack).
>
> Fix ext2_quota_write() to properly fill in number of blocks to map.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2013-12-04 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 11:57 [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota_write() Jan Kara
2013-12-03 21:13 ` Theodore Ts'o
2013-12-04 11:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204110141.GB3263@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).