* [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota_write()
@ 2013-12-03 11:57 Jan Kara
2013-12-03 21:13 ` Theodore Ts'o
2013-12-04 11:01 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kara @ 2013-12-03 11:57 UTC (permalink / raw)
To: linux-ext4; +Cc: Christoph Hellwig, Jan Kara
ext2_quota_write() doesn't properly setup bh it passes to
ext2_get_block() and thus we hit assertion BUG_ON(maxblocks == 0) in
ext2_get_blocks() (or we could actually ask for mapping arbitrary number
of blocks depending on whatever value was on stack).
Fix ext2_quota_write() to properly fill in number of blocks to map.
Reported-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext2/super.c | 1 +
1 file changed, 1 insertion(+)
I plan to send this patch to Linus soon.
Honza
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 288534920fe5..20d6697bd638 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1493,6 +1493,7 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
sb->s_blocksize - offset : towrite;
tmp_bh.b_state = 0;
+ tmp_bh.b_size = sb->s_blocksize;
err = ext2_get_block(inode, blk, &tmp_bh, 1);
if (err < 0)
goto out;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota_write()
2013-12-03 11:57 [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota_write() Jan Kara
@ 2013-12-03 21:13 ` Theodore Ts'o
2013-12-04 11:01 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2013-12-03 21:13 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4, Christoph Hellwig
On Tue, Dec 03, 2013 at 12:57:05PM +0100, Jan Kara wrote:
> ext2_quota_write() doesn't properly setup bh it passes to
> ext2_get_block() and thus we hit assertion BUG_ON(maxblocks == 0) in
> ext2_get_blocks() (or we could actually ask for mapping arbitrary number
> of blocks depending on whatever value was on stack).
>
> Fix ext2_quota_write() to properly fill in number of blocks to map.
>
> Reported-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Jan Kara <jack@suse.cz>
Looks good to me.
Reviewed-by: "Theodore Ts'o" <tytso@mit.edu>
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota_write()
2013-12-03 11:57 [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota_write() Jan Kara
2013-12-03 21:13 ` Theodore Ts'o
@ 2013-12-04 11:01 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2013-12-04 11:01 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4, Christoph Hellwig
On Tue, Dec 03, 2013 at 12:57:05PM +0100, Jan Kara wrote:
> ext2_quota_write() doesn't properly setup bh it passes to
> ext2_get_block() and thus we hit assertion BUG_ON(maxblocks == 0) in
> ext2_get_blocks() (or we could actually ask for mapping arbitrary number
> of blocks depending on whatever value was on stack).
>
> Fix ext2_quota_write() to properly fill in number of blocks to map.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-04 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-03 11:57 [PATCH] ext2: Fix oops in ext2_get_block() called from ext2_quota_write() Jan Kara
2013-12-03 21:13 ` Theodore Ts'o
2013-12-04 11:01 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).