linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 6/9] Use %pd in Ext4
       [not found] <20131210152612.4916.80435.stgit@warthog.procyon.org.uk>
@ 2013-12-10 15:26 ` David Howells
  2013-12-10 15:58   ` Theodore Ts'o
  2013-12-11 12:10   ` David Howells
  0 siblings, 2 replies; 4+ messages in thread
From: David Howells @ 2013-12-10 15:26 UTC (permalink / raw)
  To: viro; +Cc: dhowells, Theodore Ts'o, linux-ext4, Andreas Dilger,
	linux-fsdevel

Use the new %pd printk() specifier in Ext4 to replace passing of dentry name or
dentry name and name length * 2 with just passing the dentry.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: "Theodore Ts'o" <tytso@mit.edu>
cc: Andreas Dilger <adilger.kernel@dilger.ca>
cc: linux-ext4@vger.kernel.org
---

 fs/ext4/namei.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 5a0408d7b114..3e9e70663233 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1425,9 +1425,8 @@ static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, unsi
 			return ERR_PTR(-EIO);
 		}
 		if (unlikely(ino == dir->i_ino)) {
-			EXT4_ERROR_INODE(dir, "'%.*s' linked to parent dir",
-					 dentry->d_name.len,
-					 dentry->d_name.name);
+			EXT4_ERROR_INODE(dir, "'%pd' linked to parent dir",
+					 dentry);
 			return ERR_PTR(-EIO);
 		}
 		inode = ext4_iget(dir->i_sb, ino);


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 6/9] Use %pd in Ext4
  2013-12-10 15:26 ` [PATCH 6/9] Use %pd in Ext4 David Howells
@ 2013-12-10 15:58   ` Theodore Ts'o
  2013-12-11 12:10   ` David Howells
  1 sibling, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2013-12-10 15:58 UTC (permalink / raw)
  To: David Howells; +Cc: viro, linux-ext4, Andreas Dilger, linux-fsdevel

On Tue, Dec 10, 2013 at 03:26:55PM +0000, David Howells wrote:
> Use the new %pd printk() specifier in Ext4 to replace passing of dentry name or
> dentry name and name length * 2 with just passing the dentry.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: "Theodore Ts'o" <tytso@mit.edu>
> cc: Andreas Dilger <adilger.kernel@dilger.ca>
> cc: linux-ext4@vger.kernel.org

Acked-by: "Theodore Ts'o" <tytso@mit.edu>

Do you want to have Al take this, or I'm happy to carry this in the
ext4 tree.

						- Ted

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 6/9] Use %pd in Ext4
  2013-12-10 15:26 ` [PATCH 6/9] Use %pd in Ext4 David Howells
  2013-12-10 15:58   ` Theodore Ts'o
@ 2013-12-11 12:10   ` David Howells
  2014-01-06 14:43     ` Theodore Ts'o
  1 sibling, 1 reply; 4+ messages in thread
From: David Howells @ 2013-12-11 12:10 UTC (permalink / raw)
  To: Theodore Ts'o
  Cc: dhowells, viro, linux-ext4, Andreas Dilger, linux-fsdevel

Theodore Ts'o <tytso@mit.edu> wrote:

> Do you want to have Al take this, or I'm happy to carry this in the
> ext4 tree.

Can you take the Ext4 bit through your tree?

David

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 6/9] Use %pd in Ext4
  2013-12-11 12:10   ` David Howells
@ 2014-01-06 14:43     ` Theodore Ts'o
  0 siblings, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2014-01-06 14:43 UTC (permalink / raw)
  To: David Howells; +Cc: viro, linux-ext4, Andreas Dilger, linux-fsdevel

On Wed, Dec 11, 2013 at 12:10:04PM +0000, David Howells wrote:
> Theodore Ts'o <tytso@mit.edu> wrote:
> 
> > Do you want to have Al take this, or I'm happy to carry this in the
> > ext4 tree.
> 
> Can you take the Ext4 bit through your tree?

Thanks, applied to the ext4 tree.

					- Ted

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-01-06 14:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20131210152612.4916.80435.stgit@warthog.procyon.org.uk>
2013-12-10 15:26 ` [PATCH 6/9] Use %pd in Ext4 David Howells
2013-12-10 15:58   ` Theodore Ts'o
2013-12-11 12:10   ` David Howells
2014-01-06 14:43     ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).