linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: tytso@mit.edu, darrick.wong@oracle.com
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 68/74] tests: Add block_validity speed test
Date: Tue, 10 Dec 2013 17:25:52 -0800	[thread overview]
Message-ID: <20131211012552.30655.46334.stgit@birch.djwong.org> (raw)
In-Reply-To: <20131211011813.30655.39624.stgit@birch.djwong.org>

Extend the metadata checksum speed test to evaluate the performance
impact of the block_validity mount option.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/metadata-checksum-test.sh |   72 +++++++++++++++++++++++++++++++++++----
 1 file changed, 65 insertions(+), 7 deletions(-)


diff --git a/tests/metadata-checksum-test.sh b/tests/metadata-checksum-test.sh
index 1c73e58..0703501 100755
--- a/tests/metadata-checksum-test.sh
+++ b/tests/metadata-checksum-test.sh
@@ -192,6 +192,15 @@ cat > "${MKE2FS_CONFIG}" << ENDL
 	inode_ratio = 16384
 
 [fs_types]
+	ext4icsum_no_bv = {
+		features = has_journal,extent,huge_file,flex_bg,uninit_bg,dir_nlink,extra_isize,64bit$MKFS_OPTS
+		default_mntopts = acl,user_xattr
+		inode_size = ${INODE_SZ}
+		blocksize = ${BLK_SZ}
+		options = mmp_update_interval=5 #${RESIZE_PARAM}
+		lazy_itable_init = 1
+		cluster_size = $((BLK_SZ * 2))
+	}
 	ext4icsum = {
 		features = has_journal,extent,huge_file,flex_bg,uninit_bg,dir_nlink,extra_isize,64bit$MKFS_OPTS
 		inode_size = ${INODE_SZ}
@@ -3171,11 +3180,14 @@ if [ ! -r /tmp/tarfiles ]; then
 fi
 if [ ! -r /tmp/dirs -o ! -r /tmp/files -o ! -r /tmp/topdirs ]; then
 	rm -rf /tmp/dirs /tmp/files /tmp/topdirs
+	set +x
+	echo '+ create_fab_config'
 	for i in a1 a2 a3 a4 a5 a6 a7 a8 a9 aA aB aC aD aE aF; do
 		cat /tmp/tarfiles | grep ^d | awk "{printf(\"$i/%s\n\", \$6);}" >> /tmp/dirs
 		cat /tmp/tarfiles | grep -v ^d | awk "{printf(\"%s $i/%s\n\", \$3, \$6);}" >> /tmp/files
 		echo "$i" >> /tmp/topdirs
 	done
+	set -x
 fi
 if [ ! -x /tmp/fab ]; then
 	cat > /tmp/fab.c << ENDL
@@ -3188,19 +3200,28 @@ if [ ! -x /tmp/fab ]; then
 #include <stdlib.h>
 #include <errno.h>
 
+#define ZERO_BUF_SZ 65536
+char zeroes[ZERO_BUF_SZ];
+
 int main(int argc, char *argv[])
 {
 	FILE *fp;
 	int fd, ret;
-	size_t size;
+	size_t size, off, retoff;
 	char *space;
 	char buf[1024];
+	int write_files = 0;
 
 	if (argc < 2) {
 		printf("Usage: %s file_containing_sz_name_pairs\n", argv[0]);
 		return 4;
 	}
 
+	if (getenv("FAB_WRITE_FILES")) {
+		write_files = 1;
+		memset(zeroes, 0, ZERO_BUF_SZ);
+	}
+
 	fp = fopen(argv[1], "r");
 	if (!fp) {
 		perror(argv[1]);
@@ -3223,12 +3244,23 @@ int main(int argc, char *argv[])
 		}
 		size = strtoul(buf, NULL, 0);
 		if (size) {
-			ret = posix_fallocate(fd, 0, size);
-			if (ret) {
-				errno = ret;
-				perror(space);
-				close(fd);
-				break;
+			if (write_files) {
+				for (off = 0; off < size; off += ZERO_BUF_SZ) {
+					retoff = pwrite(fd, zeroes, (size - off) % ZERO_BUF_SZ, off);
+					if (retoff != (size - off) % ZERO_BUF_SZ) {
+						perror(space);
+						close(fd);
+						break;
+					}
+				}
+			} else {
+				ret = posix_fallocate(fd, 0, size);
+				if (ret) {
+					errno = ret;
+					perror(space);
+					close(fd);
+					break;
+				}
 			}
 		}
 		close(fd);
@@ -3331,6 +3363,32 @@ umount $MNT
 }
 
 #####################
+function block_validity_speed_test {
+test "${SKIP_SPEED_TESTS}" -gt 0 && return
+msg "block_validity_speed_test"
+prep_speed_test
+
+msg "No block_validity"
+$VALGRIND ${E2FSPROGS}/misc/mke2fs -T ext4icsum_no_bv $MKFS_OPTS $MKFS_FEATURES -F "${DEV}"
+test -z "$NO_CSUM" && $VALGRIND ${E2FSPROGS}/misc/tune2fs -O metadata_csum $DEV
+${E2FSPROGS}/misc/dumpe2fs -h $DEV 2> /dev/null | egrep -q "^Filesystem state:[ ]*clean$" || ${fsck_cmd} -fDy $DEV || true
+${mount_cmd} ${MOUNT_OPTS} "${DEV}" "${MNT}" -t ext4
+cd "${MNT}"
+/usr/bin/time bash -c "mkdir -p \$(cat /tmp/dirs); /tmp/fab /tmp/files; sync"
+/usr/bin/time bash -c "rm -rf \$(cat /tmp/topdirs); sync"
+cd -
+umount "${MNT}"
+
+msg "Yes block_validity"
+${mount_cmd} ${MOUNT_OPTS} "${DEV}" "${MNT}" -t ext4 -o block_validity
+cd "${MNT}"
+/usr/bin/time bash -c "mkdir -p \$(cat /tmp/dirs); /tmp/fab /tmp/files; sync"
+/usr/bin/time bash -c "rm -rf \$(cat /tmp/topdirs); sync"
+cd -
+umount "${MNT}"
+}
+
+#####################
 
 # Allow restarting of a test run by giving the test name and a plus sign.
 VERBS_LEN="${#VERBS}"


  parent reply	other threads:[~2013-12-11  1:26 UTC|newest]

Thread overview: 150+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  1:18 [PATCH v3 00/74] e2fsprogs patchbomb 12/2013 Darrick J. Wong
2013-12-11  1:18 ` [PATCH 01/74] libext2fs: don't overflow when punching indirect blocks with large blocks Darrick J. Wong
2013-12-12 17:06   ` Theodore Ts'o
2013-12-11  1:18 ` [PATCH 02/74] libext2fs: fix tests that set LARGE_FILE Darrick J. Wong
2013-12-12 17:09   ` Theodore Ts'o
2013-12-11  1:18 ` [PATCH 03/74] mke2fs: load configfile blocksize setting before 64bit checks Darrick J. Wong
2013-12-12 17:27   ` Theodore Ts'o
2013-12-12 22:28   ` Andreas Dilger
2013-12-12 23:13     ` Darrick J. Wong
2013-12-12 23:14     ` [PATCH] mke2fs: clean up kernel version tests Darrick J. Wong
2013-12-11  1:18 ` [PATCH 04/74] libext2fs: use ext2fs_punch() to truncate quota file Darrick J. Wong
2013-12-12 17:28   ` Theodore Ts'o
2013-12-12 17:36     ` Theodore Ts'o
2013-12-12 20:07       ` Darrick J. Wong
2013-12-12 20:56         ` Theodore Ts'o
2013-12-12 21:10         ` Darrick J. Wong
2013-12-11  1:18 ` [PATCH 05/74] debugfs: fix init_filesys help text Darrick J. Wong
2013-12-12 17:37   ` Theodore Ts'o
2013-12-11  1:18 ` [PATCH 06/74] tune2fs: forbid changing uuid on an uninit_bg filesystem Darrick J. Wong
2013-12-15  2:02   ` Theodore Ts'o
2013-12-11  1:19 ` [PATCH 07/74] libext2fs: tweak inline data error wording Darrick J. Wong
2013-12-13  4:33   ` Theodore Ts'o
2013-12-11  1:19 ` [PATCH 08/74] libext2fs: don't allow ridiculously large logical block numbers Darrick J. Wong
2013-12-12 17:41   ` Theodore Ts'o
2013-12-11  1:19 ` [PATCH 09/74] libext2fs: fix another minor grammatical error in the error catalog Darrick J. Wong
2013-12-12 17:42   ` Theodore Ts'o
2013-12-11  1:19 ` [PATCH 10/74] debugfs: fix various minor bogosity Darrick J. Wong
2013-12-12 17:44   ` Theodore Ts'o
2013-12-11  1:19 ` [PATCH 11/74] misc: use the checksum predicate function, not raw flag tests Darrick J. Wong
2013-12-13  4:34   ` Theodore Ts'o
2013-12-11  1:19 ` [PATCH 12/74] libext2fs: make symlinks safe for 64bit blocks and extents Darrick J. Wong
2013-12-12 17:48   ` Theodore Ts'o
2013-12-11  1:19 ` [PATCH 13/74] debugfs: handle 64bit block numbers Darrick J. Wong
2013-12-12 17:49   ` Theodore Ts'o
2013-12-17 17:01   ` Eric Sandeen
2013-12-11  1:19 ` [PATCH 14/74] libext2fs: fileio should use 64bit io routines Darrick J. Wong
2013-12-12 17:50   ` Theodore Ts'o
2013-12-11  1:20 ` [PATCH 15/74] resize2fs: rewrite extent/dir/ea block checksums when migrating Darrick J. Wong
2013-12-13  4:35   ` Theodore Ts'o
2013-12-11  1:20 ` [PATCH 16/74] debugfs: don't leak fd when calling dump_file Darrick J. Wong
2013-12-12 17:51   ` Theodore Ts'o
2013-12-11  1:20 ` [PATCH 17/74] debugfs: don't leak mmp_s memory Darrick J. Wong
2013-12-12 17:52   ` Theodore Ts'o
2013-12-12 22:33   ` Andreas Dilger
2013-12-12 22:44     ` Darrick J. Wong
2013-12-11  1:20 ` [PATCH 18/74] e2fsck: fix memory leaks Darrick J. Wong
2013-12-12 17:58   ` Theodore Ts'o
2013-12-17 16:12   ` Eric Sandeen
2013-12-11  1:20 ` [PATCH 19/74] misc: don't leak file descriptors Darrick J. Wong
2013-12-12 18:06   ` Theodore Ts'o
2013-12-11  1:20 ` [PATCH 20/74] mke2fs: don't leak memory Darrick J. Wong
2013-12-12 18:07   ` Theodore Ts'o
2013-12-11  1:20 ` [PATCH 21/74] e4defrag: don't crash if umounts the filesystem races with us Darrick J. Wong
2013-12-12 18:08   ` Theodore Ts'o
2013-12-11  1:20 ` [PATCH 22/74] e4defrag: defensively check results of sysconf(_SC_PAGESIZE) Darrick J. Wong
2013-12-12 18:09   ` Theodore Ts'o
2013-12-11  1:20 ` [PATCH 23/74] e2image: check return value from check_if_mounted Darrick J. Wong
2013-12-12 18:09   ` Theodore Ts'o
2013-12-11  1:20 ` [PATCH 24/74] dumpe2fs: check return values Darrick J. Wong
2013-12-12 18:10   ` Theodore Ts'o
2013-12-11  1:21 ` [PATCH 25/74] libss: fix fd error handling Darrick J. Wong
2013-12-12 18:11   ` Theodore Ts'o
2013-12-11  1:21 ` [PATCH 26/74] libss: fix memory handling errors Darrick J. Wong
2013-12-12 18:13   ` Theodore Ts'o
2013-12-17 17:04   ` Eric Sandeen
2013-12-18 22:23     ` Darrick J. Wong
2013-12-11  1:21 ` [PATCH 27/74] libquota: fix memory leak Darrick J. Wong
2013-12-12 18:14   ` Theodore Ts'o
2013-12-11  1:21 ` [PATCH 28/74] libext2fs: check return values Darrick J. Wong
2013-12-12 18:15   ` Theodore Ts'o
2013-12-17 16:57   ` Eric Sandeen
2013-12-17 16:59     ` Eric Sandeen
2013-12-11  1:21 ` [PATCH 29/74] libext2fs: fix memory leaks Darrick J. Wong
2013-12-12 18:17   ` Theodore Ts'o
2013-12-11  1:21 ` [PATCH 30/74] libext2fs: fix a broken close() test Darrick J. Wong
2013-12-12 18:18   ` Theodore Ts'o
2013-12-11  1:21 ` [PATCH 31/74] libext2fs: fail fileio write if we can't allocate a block Darrick J. Wong
2013-12-12 18:23   ` Theodore Ts'o
2013-12-11  1:21 ` [PATCH 32/74] libext2fs: fix punching extents when there are no left extents Darrick J. Wong
2013-12-12 18:25   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 33/74] libext2fs: don't error out when punching a totally sparse file Darrick J. Wong
2013-12-12 18:26   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 34/74] e2fsck: in rehash, mark newly allocated extent blocks as found Darrick J. Wong
2013-12-12 18:27   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 35/74] libext2fs: zero block contents past EOF when setting size Darrick J. Wong
2013-12-12 18:40   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 36/74] libext2fs: detect Darrick J. Wong
2013-12-13  4:39   ` Theodore Ts'o
2014-01-15 21:00     ` Darrick J. Wong
2013-12-11  1:22 ` [PATCH 37/74] libext2fs: don't always read backup group descriptors on a 1k-block meta_bg fs Darrick J. Wong
2014-01-11 18:59   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 38/74] libext2fs: mark group data blocks when loading block bitmap Darrick J. Wong
2014-01-11 19:08   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 39/74] e2fsck: remove uninit block bitmap calculation Darrick J. Wong
2014-01-11 19:08   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 40/74] libext2fs: no need to clear BLOCK_UNINIT during ext2fs_reserve_super_and_bgd Darrick J. Wong
2014-01-10  8:17   ` Akira Fujita
2014-01-11 19:18   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 41/74] tests: adjust test output to reflect block_uninit calculated block bitmaps Darrick J. Wong
2014-01-11 19:19   ` Theodore Ts'o
2013-12-11  1:22 ` [PATCH 42/74] libext2fs: only punch complete clusters Darrick J. Wong
2013-12-16  4:52   ` Theodore Ts'o
2013-12-11  1:23 ` [PATCH 43/74] libext2fs: don't update the summary counts when doing implied cluster allocation Darrick J. Wong
2013-12-16  4:53   ` Theodore Ts'o
2013-12-11  1:23 ` [PATCH 44/74] e2fsck: only release clusters when shortening a directory during a rehash Darrick J. Wong
2013-12-16  4:55   ` Theodore Ts'o
2013-12-11  1:23 ` [PATCH 45/74] e2fsck: print cluster ranges when encountering bitmap errors Darrick J. Wong
2013-12-16  4:55   ` Theodore Ts'o
2013-12-11  1:23 ` [PATCH 46/74] e2fsck: try implied cluster allocation when expanding a dir Darrick J. Wong
2013-12-16  4:56   ` Theodore Ts'o
2013-12-11  1:23 ` [PATCH 47/74] resize2fs: during shrink, don't free in-use bg data clusters Darrick J. Wong
2013-12-16  5:01   ` Theodore Ts'o
2013-12-16 20:10     ` Darrick J. Wong
2014-02-24  1:39       ` Theodore Ts'o
2013-12-11  1:23 ` [PATCH 48/74] resize2fs: don't free in-use clusters when moving blocks Darrick J. Wong
2014-02-24  1:56   ` Theodore Ts'o
2013-12-11  1:23 ` [PATCH 49/74] mke2fs: set block_validity as a default mount option Darrick J. Wong
2013-12-11  1:23 ` [PATCH 50/74] libext2fs: support allocating uninit blocks in bmap2() Darrick J. Wong
2014-01-11 22:57   ` Theodore Ts'o
2014-01-15 21:11     ` Darrick J. Wong
2014-01-15 22:19       ` Theodore Ts'o
2014-01-15 22:23         ` Theodore Ts'o
2013-12-11  1:23 ` [PATCH 51/74] libext2fs: file IO routines should handle uninit blocks Darrick J. Wong
2013-12-11  1:24 ` [PATCH 52/74] resize2fs: convert fs to and from 64bit mode Darrick J. Wong
2013-12-11  1:24 ` [PATCH 53/74] resize2fs: when toggling 64bit, don't free in-use bg data clusters Darrick J. Wong
2013-12-11  1:24 ` [PATCH 54/74] resize2fs: adjust reserved_gdt_blocks when changing group descriptor size Darrick J. Wong
2013-12-11  1:24 ` [PATCH 55/74] libext2fs: support modifying arbitrary extended attributes Darrick J. Wong
2014-02-24  4:09   ` Theodore Ts'o
2013-12-11  1:24 ` [PATCH 56/74] libext2fs: various tweaks to the xattr editor APIs Darrick J. Wong
2014-02-24  4:10   ` Theodore Ts'o
2013-12-11  1:24 ` [PATCH 57/74] libext2fs: extend xattr api to query number of attrs Darrick J. Wong
2014-02-24  4:10   ` Theodore Ts'o
2013-12-11  1:24 ` [PATCH 58/74] libext2fs: free key/value pairs before reading Darrick J. Wong
2014-02-24  4:10   ` Theodore Ts'o
2013-12-11  1:24 ` [PATCH 59/74] debugfs: dump all extended attributes Darrick J. Wong
2014-02-24  4:10   ` Theodore Ts'o
2013-12-11  1:24 ` [PATCH 60/74] libext2fs: ensure that inline data is always written to ibody Darrick J. Wong
2013-12-11  1:25 ` [PATCH 61/74] libext2fs: fix ext2fs_open2() truncation of the superblock parameter Darrick J. Wong
2013-12-11  1:25 ` [PATCH 62/74] misc: add fuse2fs, a FUSE server for e2fsprogs Darrick J. Wong
2013-12-11  1:25 ` [PATCH 63/74] fuse2fs: translate ACL structures Darrick J. Wong
2013-12-11  1:25 ` [PATCH 64/74] Subject: [PATCH] fuse2fs: support allocating uninit blocks in fallocate Darrick J. Wong
2013-12-11  1:25 ` [PATCH 65/74] fuse2fs: handle 64-bit dates correctly Darrick J. Wong
2013-12-11  1:25 ` [PATCH 67/74] tests: check correct handling of reading and writing uninit extents Darrick J. Wong
2013-12-11  1:25 ` Darrick J. Wong [this message]
2013-12-11  1:26 ` [PATCH 69/74] Subject: [PATCH] tests: test what happens if we run out of space Darrick J. Wong
2013-12-11  1:26 ` [PATCH 70/74] tests: add stale data after truncate test Darrick J. Wong
2013-12-11  1:26 ` [PATCH 71/74] tests: check mapping of really high logical block offsets Darrick J. Wong
2013-12-11  1:26 ` [PATCH 72/74] Subject: [PATCH] tests: enable using fuse2fs with metadata checksum test Darrick J. Wong
2013-12-11  1:26 ` [PATCH 73/74] tests: add large symlink test Darrick J. Wong
2013-12-11  1:26 ` [PATCH 74/74] tests: test date handling Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211012552.30655.46334.stgit@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).