* [PATCH] e2fsck: fix problem comments to match actual message
@ 2013-10-22 3:54 Andreas Dilger
2013-10-22 4:12 ` Dilger, Andreas
2013-12-12 1:11 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Dilger @ 2013-10-22 3:54 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4, Andreas Dilger
Fix the e2fsck problem comments to match the actual message printed,
so that it is possible to find the problem code when searching by
the message.
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
---
e2fsck/problem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index b0a6e19..2a6c937 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -1118,12 +1118,12 @@ static struct e2fsck_problem problem_table[] = {
N_("@n @i number for '.' in @d @i %i.\n"),
PROMPT_FIX, 0 },
- /* Directory entry has bad inode number */
+ /* Entry 'xxxx' in /a/b/c has bad inode number.*/
{ PR_2_BAD_INO,
N_("@E has @n @i #: %Di.\n"),
PROMPT_CLEAR, 0 },
- /* Directory entry has deleted or unused inode */
+ /* Entry 'xxxx' in /a/b/c has deleted/unused inode nnnnn.*/
{ PR_2_UNUSED_INODE,
N_("@E has @D/unused @i %Di. "),
PROMPT_CLEAR, PR_PREEN_OK },
--
1.7.11.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] e2fsck: fix problem comments to match actual message
2013-10-22 3:54 [PATCH] e2fsck: fix problem comments to match actual message Andreas Dilger
@ 2013-10-22 4:12 ` Dilger, Andreas
2013-12-12 1:11 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Dilger, Andreas @ 2013-10-22 4:12 UTC (permalink / raw)
To: tytso@mit.edu; +Cc: linux-ext4@vger.kernel.org
On 2013/10/21 9:54 PM, "Dilger, Andreas" <andreas.dilger@intel.com> wrote:
>Fix the e2fsck problem comments to match the actual message printed,
>so that it is possible to find the problem code when searching by
>the message.
Ted,
have you thought about getting rid of the error message compression in
e2fsck? I think the compression isn't useful anymore, and the escape
codes makes it much harder to debug and understand the code.
Cheers, Andreas
>Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
>---
> e2fsck/problem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/e2fsck/problem.c b/e2fsck/problem.c
>index b0a6e19..2a6c937 100644
>--- a/e2fsck/problem.c
>+++ b/e2fsck/problem.c
>@@ -1118,12 +1118,12 @@ static struct e2fsck_problem problem_table[] = {
> N_("@n @i number for '.' in @d @i %i.\n"),
> PROMPT_FIX, 0 },
>
>- /* Directory entry has bad inode number */
>+ /* Entry 'xxxx' in /a/b/c has bad inode number.*/
> { PR_2_BAD_INO,
> N_("@E has @n @i #: %Di.\n"),
> PROMPT_CLEAR, 0 },
>
>- /* Directory entry has deleted or unused inode */
>+ /* Entry 'xxxx' in /a/b/c has deleted/unused inode nnnnn.*/
> { PR_2_UNUSED_INODE,
> N_("@E has @D/unused @i %Di. "),
> PROMPT_CLEAR, PR_PREEN_OK },
>--
>1.7.11.5
>
>
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] e2fsck: fix problem comments to match actual message
2013-10-22 3:54 [PATCH] e2fsck: fix problem comments to match actual message Andreas Dilger
2013-10-22 4:12 ` Dilger, Andreas
@ 2013-12-12 1:11 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2013-12-12 1:11 UTC (permalink / raw)
To: Andreas Dilger; +Cc: linux-ext4
On Mon, Oct 21, 2013 at 09:54:07PM -0600, Andreas Dilger wrote:
> Fix the e2fsck problem comments to match the actual message printed,
> so that it is possible to find the problem code when searching by
> the message.
>
> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-12 1:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 3:54 [PATCH] e2fsck: fix problem comments to match actual message Andreas Dilger
2013-10-22 4:12 ` Dilger, Andreas
2013-12-12 1:11 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).