* [PATCH v2] mke2fs: fix force option to create filesystem on mounted device
@ 2013-11-29 6:30 Kazuya Mio
2013-12-16 5:43 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Kazuya Mio @ 2013-11-29 6:30 UTC (permalink / raw)
To: tytso, 'Andreas Dilger'; +Cc: linux-ext4
This is v2 patch added reviewed-by.
Could you check and merge this patch if possible?
According to mke2fs man, we can create a filesystem on the mounted device
when -FF option is specified.
However, currently we have to specify -F option third to force mke2fs.
This patch fixes the problem.
Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
---
misc/util.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/misc/util.c b/misc/util.c
index 6c93e1c..40c8858 100644
--- a/misc/util.c
+++ b/misc/util.c
@@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
}
if (mount_flags & EXT2_MF_MOUNTED) {
fprintf(stderr, _("%s is mounted; "), device);
- if (force > 2) {
+ if (force >= 2) {
fputs(_("mke2fs forced anyway. Hope /etc/mtab is "
"incorrect.\n"), stderr);
return;
@@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
if (mount_flags & EXT2_MF_BUSY) {
fprintf(stderr, _("%s is apparently in use by the system; "),
device);
- if (force > 2) {
+ if (force >= 2) {
fputs(_("mke2fs forced anyway.\n"), stderr);
return;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mke2fs: fix force option to create filesystem on mounted device
2013-11-29 6:30 [PATCH v2] mke2fs: fix force option to create filesystem on mounted device Kazuya Mio
@ 2013-12-16 5:43 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-12-16 5:43 UTC (permalink / raw)
To: Kazuya Mio; +Cc: 'Andreas Dilger', linux-ext4
On Fri, Nov 29, 2013 at 03:30:41PM +0900, Kazuya Mio wrote:
>
> According to mke2fs man, we can create a filesystem on the mounted device
> when -FF option is specified.
> However, currently we have to specify -F option third to force mke2fs.
> This patch fixes the problem.
>
> Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
> Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-16 5:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-29 6:30 [PATCH v2] mke2fs: fix force option to create filesystem on mounted device Kazuya Mio
2013-12-16 5:43 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).