* Re: [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size
[not found] <1387435099-11163-1-git-send-email-yangyongqiang01@baidu.com>
@ 2013-12-19 6:40 ` Yongqiang Yang
2013-12-20 4:22 ` Theodore Ts'o
0 siblings, 1 reply; 4+ messages in thread
From: Yongqiang Yang @ 2013-12-19 6:40 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: Ext4 Developers List, Theodore Ts'o
can be reproduced by xfstests 62 with bigalloc and 128bit size inode.
Thanks,
Yongqiang.
On Thu, Dec 19, 2013 at 2:38 PM, Yongqiang Yang
<yangyongqiang01@baidu.com> wrote:
> From: Yongqiang Yang <xiaoqiangnk@gmail.com>
>
> Signed-off-by: Yongqiang Yang <yangyongqiang01@baidu.com>
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9115f28..1869fcf 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -145,7 +145,7 @@ static int ext4_meta_trans_blocks(struct inode *inode, int lblocks,
> static int ext4_inode_is_fast_symlink(struct inode *inode)
> {
> int ea_blocks = EXT4_I(inode)->i_file_acl ?
> - (inode->i_sb->s_blocksize >> 9) : 0;
> + EXT4_CLUSTER_SIZE(inode->i_sb) >> 9 : 0;
>
> return (S_ISLNK(inode->i_mode) && inode->i_blocks - ea_blocks == 0);
> }
> --
> 1.8.5.2
>
--
Best Wishes
Yongqiang Yang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size
2013-12-19 6:40 ` [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size Yongqiang Yang
@ 2013-12-20 4:22 ` Theodore Ts'o
2013-12-20 4:58 ` Yongqiang Yang
0 siblings, 1 reply; 4+ messages in thread
From: Theodore Ts'o @ 2013-12-20 4:22 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: Yongqiang Yang, Ext4 Developers List
On Thu, Dec 19, 2013 at 02:40:42PM +0800, Yongqiang Yang wrote:
> can be reproduced by xfstests 62 with bigalloc and 128bit size inode.
Hi Yongqiang,
I can't find the original message you were replying. I can
reconstruct the 2/2 patch, but is there a 1/2 patch that you had meant
to send to the linux-ext4 list?
Many thanks,
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size
2013-12-20 4:22 ` Theodore Ts'o
@ 2013-12-20 4:58 ` Yongqiang Yang
2013-12-20 5:01 ` Theodore Ts'o
0 siblings, 1 reply; 4+ messages in thread
From: Yongqiang Yang @ 2013-12-20 4:58 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Yongqiang Yang, Ext4 Developers List
On Fri, Dec 20, 2013 at 12:22 PM, Theodore Ts'o <tytso@mit.edu> wrote:
> On Thu, Dec 19, 2013 at 02:40:42PM +0800, Yongqiang Yang wrote:
>> can be reproduced by xfstests 62 with bigalloc and 128bit size inode.
>
> Hi Yongqiang,
>
> I can't find the original message you were replying. I can
> reconstruct the 2/2 patch, but is there a 1/2 patch that you had meant
> to send to the linux-ext4 list?
Interesting, I sent the patch to ext4 list and you. I will resend them.
Thanks,
Yongqiang.
>
> Many thanks,
>
> - Ted
--
Best Wishes
Yongqiang Yang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size
2013-12-20 4:58 ` Yongqiang Yang
@ 2013-12-20 5:01 ` Theodore Ts'o
0 siblings, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2013-12-20 5:01 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: Yongqiang Yang, Ext4 Developers List
On Fri, Dec 20, 2013 at 12:58:47PM +0800, Yongqiang Yang wrote:
> > I can't find the original message you were replying. I can
> > reconstruct the 2/2 patch, but is there a 1/2 patch that you had meant
> > to send to the linux-ext4 list?
> Interesting, I sent the patch to ext4 list and you. I will resend them.
Thanks. I couldn't find the patches on either gmane[1] or patchwork[2].
[1] http://news.gmane.org/gmane.comp.file-systems.ext4
[2] http://patchwork.ozlabs.org/project/linux-ext4/list/
So I'm guessing it got lost before reaching vger.kernel.org.
regards,
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-20 5:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1387435099-11163-1-git-send-email-yangyongqiang01@baidu.com>
2013-12-19 6:40 ` [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size Yongqiang Yang
2013-12-20 4:22 ` Theodore Ts'o
2013-12-20 4:58 ` Yongqiang Yang
2013-12-20 5:01 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).