From: Theodore Ts'o <tytso@mit.edu>
To: PaX Team <pageexec@freemail.hu>
Cc: linux-ext4@vger.kernel.org, re.emese@gmail.com
Subject: Re: possible unintended integer truncation in fs/ext4/extents.c:get_implied_cluster_alloc
Date: Fri, 20 Dec 2013 00:12:56 -0500 [thread overview]
Message-ID: <20131220051256.GD23508@thunk.org> (raw)
In-Reply-To: <20131220045920.GB23508@thunk.org>
On Thu, Dec 19, 2013 at 11:59:20PM -0500, Theodore Ts'o wrote:
> So C's integer promotion and sign extension rules are very obscure and
> confusing, and that may be a reason why we should put in an explicit
> cast, but it looks like the right thing is happening here. Here's a
> test program --- what am I missing?
Never mind, I see the problem. It works if cr is a short, but not if
it is an unsigned int. Sigh...
- Ted
prev parent reply other threads:[~2013-12-20 5:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 22:29 possible unintended integer truncation in fs/ext4/extents.c:get_implied_cluster_alloc PaX Team
2013-12-20 4:59 ` Theodore Ts'o
2013-12-20 5:12 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220051256.GD23508@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=pageexec@freemail.hu \
--cc=re.emese@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).