From: Theodore Ts'o <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] debugfs: silence build warning and remove incorrect error message
Date: Tue, 24 Dec 2013 11:05:17 -0500 [thread overview]
Message-ID: <20131224160517.GD26944@thunk.org> (raw)
In-Reply-To: <20131223023035.GA2396@wallace>
On Sun, Dec 22, 2013 at 09:30:35PM -0500, Eric Whitney wrote:
> Commit fe56188b07 modified the code used to check the block number
> argument to the command line -s switch, adding a call to com_err().
> This causes a compile time warning because the third argument to
> com_err() isn't a string. Also, when the block number argument is
> bad it outputs an incorrect error message - "Operation not permitted".
>
> Fix these minor problems by removing the call to com_err(). Other
> code provides enough error reporting information in this case.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2013-12-24 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 2:30 [PATCH] debugfs: silence build warning and remove incorrect error message Eric Whitney
2013-12-24 16:05 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131224160517.GD26944@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).