From: Theodore Ts'o <tytso@mit.edu>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e4defrag: choose the best available posix_fadvise variant
Date: Thu, 2 Jan 2014 19:47:10 -0500 [thread overview]
Message-ID: <20140103004710.GA31411@thunk.org> (raw)
In-Reply-To: <23c2b99441922fe311235e241eca52e9701e54d4.1388645034.git.baruch@tkos.co.il>
On Thu, Jan 02, 2014 at 08:43:54AM +0200, Baruch Siach wrote:
> Use posix_fadvise64() when available. This allows 64bit offsets on 32bit
> systems.
>
> Rename the internal posix_fadvise() implementation to avoid collision with the
> C library signature that is sometimes present event when the implementation
> itself is not. This fixes build errors like:
>
> e4defrag.c:189:2: warning: #warning Using locally defined posix_fadvise interface. [-Wcpp
> e4defrag.c:203:12: error: conflicting types for ‘posix_fadvise’
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Thanks, applied.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-03 0:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 6:43 [PATCH] e4defrag: choose the best available posix_fadvise variant Baruch Siach
2014-01-03 0:47 ` Theodore Ts'o [this message]
2014-01-03 4:57 ` Baruch Siach
2014-01-03 16:23 ` Theodore Ts'o
2014-01-05 6:12 ` Theodore Ts'o
2014-01-05 6:46 ` Baruch Siach
2014-01-05 14:00 ` Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2014-01-02 6:55 Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103004710.GA31411@thunk.org \
--to=tytso@mit.edu \
--cc=baruch@tkos.co.il \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).