linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] mke2fs: add make_hugefile feature
Date: Tue, 21 Jan 2014 18:41:41 -0500	[thread overview]
Message-ID: <20140121234141.GI31769@thunk.org> (raw)
In-Reply-To: <20140121192356.GQ9229@birch.djwong.org>

On Tue, Jan 21, 2014 at 11:23:56AM -0800, Darrick J. Wong wrote:
> 
> I'd adapt fuse2fs to use a ext2fs_fallocate function, if one existed.  That
> said, it would have to be more general than this, handling the case where there
> might be blocks mapped.
> 
> Hey Ted, if I wrote an ext2fs_fallocate, would you adapt this for it?

Sure, if there was an ext2fs_fallocate() which is as CPU efficient as
what I currently have, and which produces an extent tree which is as
efficient, I'd certainly use it.  

% /usr/bin/time ./mke2fs -F -q  -T hugefile /tmp/foo.img 4T
0.09user 0.28system 0:00.37elapsed 99%CPU (0avgtext+0avgdata 2160maxresident)k
0inputs+0outputs (0major+592minor)pagefaults 0swaps

% debugfs -R "stat /database/storage" /tmp/foo.img | head -10
debugfs 1.42.9 (28-Dec-2013)
Inode: 13   Type: regular    Mode:  0600   Flags: 0x80000
Generation: 0    Version: 0x00000000
User:   120   Group:    50   Size: 4397641728000
File ACL: 0    Directory ACL: 0
Links: 1   Blockcount: 8589145544
     ...

So I can currently do the equivalent of fallocating close to 4TB in
less than a half a second.  This includes searching for free blocks
from the allocation bitmap, and setting up the extent tree, and making
sure all of the block group checksums are correct.  (And oh yes, that
includes making the file system and setting up all of the block group
descriptors as well.)

Try doing this via the existing interfaces, and see what you get.
It's not pretty.  :-)

The one area where we still have some improvements to do after all of
my changes to libext2fs is that ext2fs_extent_node_split() needs to be
taught that if the current location of the extent handle is at the
very end of the file, then when instead of splitting the last leaf
block 50/50, we should split the node unevenly, by creating a new leaf
block that has only a single entry in it --- the last extent of the
file.  That we can use close to 100% of the extent block's space,
instead of currently where we averaging around 170 extents per 4k
block, instead of 340.

Cheers,

						- Ted

  reply	other threads:[~2014-01-21 23:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-21  6:17 [PATCH] mke2fs: add make_hugefile feature Theodore Ts'o
2014-01-21 18:45 ` Andreas Dilger
2014-01-21 19:23   ` Darrick J. Wong
2014-01-21 23:41     ` Theodore Ts'o [this message]
2014-01-22  3:16       ` Darrick J. Wong
2014-01-21 21:39   ` Theodore Ts'o
2014-01-24  1:37     ` Darrick J. Wong
2014-02-21  2:23       ` [PATCH] ext4: merge uninitialized extents Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140121234141.GI31769@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).