* [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c
[not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com>
@ 2014-02-09 13:04 ` Rashika Kheria
2014-02-11 20:48 ` Jan Kara
2014-02-09 13:06 ` [PATCH 08/21] fs: Mark function as static in ext3/dir.c Rashika Kheria
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Rashika Kheria @ 2014-02-09 13:04 UTC (permalink / raw)
To: linux-kernel; +Cc: Jan Kara, linux-ext4, josh
Mark function as static in ext2/xattr_security.c because it is not
used outside this file.
This also elimiantes the following warning in ext2/xattr_security.c:
fs/ext2/xattr_security.c:45:5: warning: no previous prototype for ‘ext2_initxattrs’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
fs/ext2/xattr_security.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
index cfedb2c..c0ebc4d 100644
--- a/fs/ext2/xattr_security.c
+++ b/fs/ext2/xattr_security.c
@@ -42,8 +42,8 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
value, size, flags);
}
-int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
- void *fs_info)
+static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+ void *fs_info)
{
const struct xattr *xattr;
int err = 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c
2014-02-09 13:04 ` [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Rashika Kheria
@ 2014-02-11 20:48 ` Jan Kara
0 siblings, 0 replies; 9+ messages in thread
From: Jan Kara @ 2014-02-11 20:48 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, Jan Kara, linux-ext4, josh
On Sun 09-02-14 18:34:10, Rashika Kheria wrote:
> Mark function as static in ext2/xattr_security.c because it is not
> used outside this file.
>
> This also elimiantes the following warning in ext2/xattr_security.c:
> fs/ext2/xattr_security.c:45:5: warning: no previous prototype for ‘ext2_initxattrs’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thanks. I've merged the patch.
Honza
> ---
> fs/ext2/xattr_security.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
> index cfedb2c..c0ebc4d 100644
> --- a/fs/ext2/xattr_security.c
> +++ b/fs/ext2/xattr_security.c
> @@ -42,8 +42,8 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
> value, size, flags);
> }
>
> -int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> - void *fs_info)
> +static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> + void *fs_info)
> {
> const struct xattr *xattr;
> int err = 0;
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 08/21] fs: Mark function as static in ext3/dir.c
[not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com>
2014-02-09 13:04 ` [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Rashika Kheria
@ 2014-02-09 13:06 ` Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:09 ` [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c Rashika Kheria
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
3 siblings, 1 reply; 9+ messages in thread
From: Rashika Kheria @ 2014-02-09 13:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4, josh
Mark function as static in ext3/dir.c because it is not used outside
this file.
This also eliminates the following warning in ext3/dir.c:
fs/ext3/dir.c:278:8: warning: no previous prototype for ‘ext3_dir_llseek’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
fs/ext3/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c
index e66e480..17742ee 100644
--- a/fs/ext3/dir.c
+++ b/fs/ext3/dir.c
@@ -275,7 +275,7 @@ static inline loff_t ext3_get_htree_eof(struct file *filp)
* NOTE: offsets obtained *before* ext3_set_inode_flag(dir, EXT3_INODE_INDEX)
* will be invalid once the directory was converted into a dx directory
*/
-loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence)
+static loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence)
{
struct inode *inode = file->f_mapping->host;
int dx_dir = is_dx_dir(inode);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 08/21] fs: Mark function as static in ext3/dir.c
2014-02-09 13:06 ` [PATCH 08/21] fs: Mark function as static in ext3/dir.c Rashika Kheria
@ 2014-02-11 20:49 ` Jan Kara
0 siblings, 0 replies; 9+ messages in thread
From: Jan Kara @ 2014-02-11 20:49 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4,
josh
On Sun 09-02-14 18:36:27, Rashika Kheria wrote:
> Mark function as static in ext3/dir.c because it is not used outside
> this file.
>
> This also eliminates the following warning in ext3/dir.c:
> fs/ext3/dir.c:278:8: warning: no previous prototype for ‘ext3_dir_llseek’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thanks. I've merged the patch.
Honza
> ---
> fs/ext3/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c
> index e66e480..17742ee 100644
> --- a/fs/ext3/dir.c
> +++ b/fs/ext3/dir.c
> @@ -275,7 +275,7 @@ static inline loff_t ext3_get_htree_eof(struct file *filp)
> * NOTE: offsets obtained *before* ext3_set_inode_flag(dir, EXT3_INODE_INDEX)
> * will be invalid once the directory was converted into a dx directory
> */
> -loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence)
> +static loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence)
> {
> struct inode *inode = file->f_mapping->host;
> int dx_dir = is_dx_dir(inode);
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c
[not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com>
2014-02-09 13:04 ` [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Rashika Kheria
2014-02-09 13:06 ` [PATCH 08/21] fs: Mark function as static in ext3/dir.c Rashika Kheria
@ 2014-02-09 13:09 ` Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
3 siblings, 1 reply; 9+ messages in thread
From: Rashika Kheria @ 2014-02-09 13:09 UTC (permalink / raw)
To: linux-kernel; +Cc: Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4, josh
Mark function as static in ext3/xattr_security.c because it is not used
outside this file.
This eliminates the following warning in ext3/xattr_security.c:
fs/ext3/xattr_security.c:46:5: warning: no previous prototype for ‘ext3_initxattrs’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
fs/ext3/xattr_security.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
index 3387664..722c2bf 100644
--- a/fs/ext3/xattr_security.c
+++ b/fs/ext3/xattr_security.c
@@ -43,8 +43,9 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
name, value, size, flags);
}
-int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
- void *fs_info)
+static int ext3_initxattrs(struct inode *inode,
+ const struct xattr *xattr_array,
+ void *fs_info)
{
const struct xattr *xattr;
handle_t *handle = fs_info;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c
2014-02-09 13:09 ` [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c Rashika Kheria
@ 2014-02-11 20:49 ` Jan Kara
0 siblings, 0 replies; 9+ messages in thread
From: Jan Kara @ 2014-02-11 20:49 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4,
josh
On Sun 09-02-14 18:39:11, Rashika Kheria wrote:
> Mark function as static in ext3/xattr_security.c because it is not used
> outside this file.
>
> This eliminates the following warning in ext3/xattr_security.c:
> fs/ext3/xattr_security.c:46:5: warning: no previous prototype for ‘ext3_initxattrs’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thanks. I've merged the patch.
Honza
> ---
> fs/ext3/xattr_security.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3387664..722c2bf 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -43,8 +43,9 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
> name, value, size, flags);
> }
>
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> - void *fs_info)
> +static int ext3_initxattrs(struct inode *inode,
> + const struct xattr *xattr_array,
> + void *fs_info)
> {
> const struct xattr *xattr;
> handle_t *handle = fs_info;
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c
[not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com>
` (2 preceding siblings ...)
2014-02-09 13:09 ` [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c Rashika Kheria
@ 2014-02-09 13:11 ` Rashika Kheria
2014-02-10 2:59 ` Darrick J. Wong
2014-02-12 17:36 ` Theodore Ts'o
3 siblings, 2 replies; 9+ messages in thread
From: Rashika Kheria @ 2014-02-09 13:11 UTC (permalink / raw)
To: linux-kernel; +Cc: Theodore Ts'o, linux-ext4, josh
Mark functions as static in jbd2/journal.c because they are not used
outside this file.
This eliminates the following warning in jbd2/journal.c:
fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes]
fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes]
fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
fs/jbd2/journal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 5fa344a..244b6f6 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -122,7 +122,7 @@ EXPORT_SYMBOL(__jbd2_debug);
#endif
/* Checksumming functions */
-int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
+static int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
{
if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
return 1;
@@ -143,7 +143,7 @@ static __be32 jbd2_superblock_csum(journal_t *j, journal_superblock_t *sb)
return cpu_to_be32(csum);
}
-int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
+static int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
{
if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
return 1;
@@ -151,7 +151,7 @@ int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
return sb->s_checksum == jbd2_superblock_csum(j, sb);
}
-void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
+static void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
{
if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
return;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
@ 2014-02-10 2:59 ` Darrick J. Wong
2014-02-12 17:36 ` Theodore Ts'o
1 sibling, 0 replies; 9+ messages in thread
From: Darrick J. Wong @ 2014-02-10 2:59 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, Theodore Ts'o, linux-ext4, josh
On Sun, Feb 09, 2014 at 06:41:21PM +0530, Rashika Kheria wrote:
> Mark functions as static in jbd2/journal.c because they are not used
> outside this file.
>
> This eliminates the following warning in jbd2/journal.c:
> fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Looks fine to me, so you can add
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/jbd2/journal.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 5fa344a..244b6f6 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -122,7 +122,7 @@ EXPORT_SYMBOL(__jbd2_debug);
> #endif
>
> /* Checksumming functions */
> -int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
> +static int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return 1;
> @@ -143,7 +143,7 @@ static __be32 jbd2_superblock_csum(journal_t *j, journal_superblock_t *sb)
> return cpu_to_be32(csum);
> }
>
> -int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> +static int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return 1;
> @@ -151,7 +151,7 @@ int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> return sb->s_checksum == jbd2_superblock_csum(j, sb);
> }
>
> -void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
> +static void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
2014-02-10 2:59 ` Darrick J. Wong
@ 2014-02-12 17:36 ` Theodore Ts'o
1 sibling, 0 replies; 9+ messages in thread
From: Theodore Ts'o @ 2014-02-12 17:36 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, linux-ext4, josh
On Sun, Feb 09, 2014 at 06:41:21PM +0530, Rashika Kheria wrote:
> Mark functions as static in jbd2/journal.c because they are not used
> outside this file.
>
> This eliminates the following warning in jbd2/journal.c:
> fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thanks, applied to the ext4 tree.
- Ted
^ permalink raw reply [flat|nested] 9+ messages in thread