From: Jan Kara <jack@suse.cz>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c
Date: Tue, 11 Feb 2014 21:49:16 +0100 [thread overview]
Message-ID: <20140211204916.GE22835@quack.suse.cz> (raw)
In-Reply-To: <bcf66d9631e4094a46e539950331f79289e4d85a.1391949868.git.rashika.kheria@gmail.com>
On Sun 09-02-14 18:39:11, Rashika Kheria wrote:
> Mark function as static in ext3/xattr_security.c because it is not used
> outside this file.
>
> This eliminates the following warning in ext3/xattr_security.c:
> fs/ext3/xattr_security.c:46:5: warning: no previous prototype for ‘ext3_initxattrs’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Thanks. I've merged the patch.
Honza
> ---
> fs/ext3/xattr_security.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3387664..722c2bf 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -43,8 +43,9 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
> name, value, size, flags);
> }
>
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> - void *fs_info)
> +static int ext3_initxattrs(struct inode *inode,
> + const struct xattr *xattr_array,
> + void *fs_info)
> {
> const struct xattr *xattr;
> handle_t *handle = fs_info;
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-02-11 20:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com>
2014-02-09 13:04 ` [PATCH 07/21] fs: Mark function as static in ext2/xattr_security.c Rashika Kheria
2014-02-11 20:48 ` Jan Kara
2014-02-09 13:06 ` [PATCH 08/21] fs: Mark function as static in ext3/dir.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara
2014-02-09 13:09 ` [PATCH 09/21] fs: Mark function as static in ext3/xattr_security.c Rashika Kheria
2014-02-11 20:49 ` Jan Kara [this message]
2014-02-09 13:11 ` [PATCH 11/21] fs: Mark functions as static in jbd2/journal.c Rashika Kheria
2014-02-10 2:59 ` Darrick J. Wong
2014-02-12 17:36 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211204916.GE22835@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).