From: Theodore Ts'o <tytso@mit.edu>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, joe@perches.com
Subject: Re: [PATCH] ext4: address a benign compiler warning
Date: Mon, 17 Feb 2014 20:43:54 -0500 [thread overview]
Message-ID: <20140218014354.GE26580@thunk.org> (raw)
In-Reply-To: <1392264724-10542-1-git-send-email-patrick@parcs.ath.cx>
On Wed, Feb 12, 2014 at 11:12:04PM -0500, Patrick Palka wrote:
> When !defined(CONFIG_EXT4_DEBUG), mb_debug() should be defined as a
> no_printk() statement instead of an empty statement in order to suppress
> the following compiler warning:
>
> fs/ext4/mballoc.c: In function ‘ext4_mb_cleanup_pa’:
> fs/ext4/mballoc.c:2659:47: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> mb_debug(1, "mballoc: %u PAs left\n", count);
>
> Signed-off-by: Patrick Palka <patrick@parcs.ath.cx>
Thanks, applied.
- Ted
prev parent reply other threads:[~2014-02-18 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 2:13 [PATCH] ext4: address a benign compiler warning Patrick Palka
2014-02-13 2:59 ` Joe Perches
2014-02-13 4:03 ` Patrick Palka
2014-02-13 4:12 ` Patrick Palka
2014-02-18 1:43 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218014354.GE26580@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=joe@perches.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).