From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: jack@suse.cz, "Namjae Jeon" <namjae.jeon@samsung.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com, bpm@sgi.com,
adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk,
"Ashish Sangwan" <a.sangwan@samsung.com>,
linux-fsdevel@vger.kernel.org,
"Lukáš Czerner" <lczerner@redhat.com>,
linux-ext4@vger.kernel.org, mtk.manpages@gmail.com
Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
Date: Tue, 18 Feb 2014 09:30:05 -0500 [thread overview]
Message-ID: <20140218143005.GO26580@thunk.org> (raw)
In-Reply-To: <CAKYAXd_xpWg-=T_1PghL_u9wDKTX_Ey5mJxbgVVKth8NoexQQg@mail.gmail.com>
Namjae,
Did you respond to Matthew Wilcox's comments/question from Feb. 2nd?
> > What if the file is mmaped at the time somebody issues this command?
> > Seems to me we should drop pagecache pages that overlap with the
> > removed blocks. If the removed range is not a multiple of PAGE_SIZE,
> > then we should also drop any pagecache pages after the removed range.
>
> Oops, forgot to add "and if it is a multiple of page size, then we need
> to update the offsets of any pages after the removed page".
Dave responded that XFS does the right thing when doing a punch hole
operation, but it wasn't obvious to me whether FL_COLLAPSE_RANGE does
the right thing with ext4.
Thanks,
- Ted
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-18 14:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 5:44 [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate Namjae Jeon
2014-02-10 23:34 ` Dave Chinner
2014-02-11 11:59 ` Lukáš Czerner
2014-02-12 2:28 ` Namjae Jeon
2014-02-18 9:05 ` Lukáš Czerner
2014-02-18 9:46 ` Dave Chinner
2014-02-18 9:50 ` Namjae Jeon
2014-02-18 14:30 ` Theodore Ts'o [this message]
2014-02-19 1:08 ` Namjae Jeon
2014-02-25 19:08 ` [PATCH] util-linux/fallocate: introduce an option -c to support FALLOC_FL_COLLAPSE_RANGE Dongsu Park
2014-02-25 19:31 ` Dave Chinner
2014-02-27 10:27 ` Dongsu Park
2014-02-27 3:59 ` Namjae Jeon
2014-02-27 10:35 ` [PATCH v2] util-linux/fallocate: introduce an option -c to support COLLAPSE_RANGE Dongsu Park
2014-04-18 10:52 ` Karel Zak
2014-02-27 9:00 ` [PATCH] util-linux/fallocate: introduce an option -c to support FALLOC_FL_COLLAPSE_RANGE Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218143005.GO26580@thunk.org \
--to=tytso@mit.edu \
--cc=a.sangwan@samsung.com \
--cc=adilger.kernel@dilger.ca \
--cc=bpm@sgi.com \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linkinjeon@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=namjae.jeon@samsung.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).